1783935 - Add JSContext-free variant of js::ReportAllocationOverflow()

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Bryan Thrall [:bthrall]]

js::ReportAllocationOverflow() requires a JSContext, but is called in several places during compilation (see here , here, and here).

To remove JSContext from off-thread compilation, we need a version of js::ReportAllocationOverflow() that uses ErrorContext.

Comment 1

[Bryan Thrall [:bthrall]]

Attachment: Bug 1783935 - Add ReportAllocationOverflow(ErrorContext*) and use it r=nbp

Comment 2

[Bryan Thrall [:bthrall]]

Attachment: Bug 1783935 - Remove unused JSContext parameters r=nbp

Depends on D154695

Comment 3

[Bryan Thrall [:bthrall]]

Attachment: Bug 1783935 - Pass ErrorContext to ReportAllocationOverflow() in AllocSrcNote(), ImmutableScriptData::new_() r=nbp

Depends on D154696

Comment 4

[Bryan Thrall [:bthrall]]

Attachment: Bug 1783935 - Pass ErrorContext to ReportAllocationOverflow() in NodeBuilder r=nbp

Depends on D154697

Comment 5

[Bryan Thrall [:bthrall]]

Attachment: Bug 1783935 - Remove unneeded JSContext parameters r=nbp

Depends on D154698

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a742bc90d612
Add ReportAllocationOverflow(ErrorContext*) and use it r=nbp
https://hg.mozilla.org/integration/autoland/rev/818027e6e073
Remove unused JSContext parameters r=nbp
https://hg.mozilla.org/integration/autoland/rev/dd8f7478f2c3
Pass ErrorContext to ReportAllocationOverflow() in AllocSrcNote(),  ImmutableScriptData::new_() r=nbp
https://hg.mozilla.org/integration/autoland/rev/133cbfc2a1ca
Pass ErrorContext to ReportAllocationOverflow() in NodeBuilder r=nbp
https://hg.mozilla.org/integration/autoland/rev/7259398085eb
Remove unneeded JSContext parameters r=nbp

Comment 7

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/a742bc90d612
https://hg.mozilla.org/mozilla-central/rev/818027e6e073
https://hg.mozilla.org/mozilla-central/rev/dd8f7478f2c3
https://hg.mozilla.org/mozilla-central/rev/133cbfc2a1ca
https://hg.mozilla.org/mozilla-central/rev/7259398085eb