Closed
Bug 1783935
Opened 2 years ago
Closed 2 years ago
Add JSContext-free variant of js::ReportAllocationOverflow()
Categories
(Core :: JavaScript Engine, task, P1)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
105 Branch
| Tracking | Status | |
|---|---|---|
| firefox105 | --- | fixed |
People
(Reporter: bthrall, Assigned: bthrall)
References
Details
Attachments
(5 files)
js::ReportAllocationOverflow() requires a JSContext, but is called in several places during compilation (see here , here, and here).
To remove JSContext from off-thread compilation, we need a version of js::ReportAllocationOverflow() that uses ErrorContext.
|
Assignee | |
Updated•2 years ago
|
Assignee: nobody → bthrall
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•2 years ago
|
||
|
|
Assignee | |
Comment 2•2 years ago
|
||
Depends on D154695
|
|
Assignee | |
Comment 3•2 years ago
|
||
Depends on D154696
|
|
Assignee | |
Comment 4•2 years ago
|
||
Depends on D154697
|
|
Assignee | |
Comment 5•2 years ago
|
||
Depends on D154698
|
||
Updated•2 years ago
|
Attachment #9289961 -
Attachment description: WIP: Bug 1783935 - Add ReportAllocationOverflow(ErrorContext*) and use it → Bug 1783935 - Add ReportAllocationOverflow(ErrorContext*) and use it r=nbp
|
|
||
Updated•2 years ago
|
Attachment #9289962 -
Attachment description: WIP: Bug 1783935 - Remove unused JSContext parameters → Bug 1783935 - Remove unused JSContext parameters r=nbp
|
|
||
Updated•2 years ago
|
Attachment #9289963 -
Attachment description: WIP: Bug 1783935 - Pass ErrorContext to ReportAllocationOverflow() in AllocSrcNote(), ImmutableScriptData::new_() → Bug 1783935 - Pass ErrorContext to ReportAllocationOverflow() in AllocSrcNote(), ImmutableScriptData::new_() r=nbp
|
|
||
Updated•2 years ago
|
Attachment #9289964 -
Attachment description: WIP: Bug 1783935 - Pass ErrorContext to ReportAllocationOverflow() in NodeBuilder → Bug 1783935 - Pass ErrorContext to ReportAllocationOverflow() in NodeBuilder r=nbp
|
|
||
Updated•2 years ago
|
Attachment #9289965 -
Attachment description: WIP: Bug 1783935 - Remove unneeded JSContext parameters → Bug 1783935 - Remove unneeded JSContext parameters r=nbp
|
||
Updated•2 years ago
|
Severity: -- → N/A
Priority: -- → P1
Pushed by bthrall@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a742bc90d612 Add ReportAllocationOverflow(ErrorContext*) and use it r=nbp https://hg.mozilla.org/integration/autoland/rev/818027e6e073 Remove unused JSContext parameters r=nbp https://hg.mozilla.org/integration/autoland/rev/dd8f7478f2c3 Pass ErrorContext to ReportAllocationOverflow() in AllocSrcNote(), ImmutableScriptData::new_() r=nbp https://hg.mozilla.org/integration/autoland/rev/133cbfc2a1ca Pass ErrorContext to ReportAllocationOverflow() in NodeBuilder r=nbp https://hg.mozilla.org/integration/autoland/rev/7259398085eb Remove unneeded JSContext parameters r=nbp
|
||
Comment 7•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a742bc90d612
https://hg.mozilla.org/mozilla-central/rev/818027e6e073
https://hg.mozilla.org/mozilla-central/rev/dd8f7478f2c3
https://hg.mozilla.org/mozilla-central/rev/133cbfc2a1ca
https://hg.mozilla.org/mozilla-central/rev/7259398085eb
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox105:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•