1782569 - Add JSContext-free variant of js::ReportOutOfMemory()

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Description

[Bryan Thrall [:bthrall]]

js::ReportOutOfMemory() requires a JSContext, but is called in several places during compilation (see here , here, and here).

To remove JSContext from off-thread compilation, we need a version of js::ReportOutOfMemory() that uses ErrorContext.

Comment 1

[Bryan Thrall [:bthrall]]

Attachment: Bug 1782569 - Extract JSContext::onOutOfMemory() r=nbp

Following the pattern set by JS::ReportOverRecursed().

Comment 2

[Bryan Thrall [:bthrall]]

Attachment: Bug 1782569 - Add JS::ReportOutOfMemory(ErrorContext*) r=nbp

Depends on D153961

Comment 3

[Bryan Thrall [:bthrall]]

Attachment: Bug 1782569 - Use ErrorContext instead of JSContext for off-thread ReportOutOfMemory() r=nbp

JSErrorNotes::addNoteASCII() is the only one currently required for off-thread
compiling, but I added support for addNoteLatin1() and addNoteUTF8() for
consistency.

ErrorArgumentsType declaration moved to ErrorReport.h to resolve header
#include recursion.

There's no need to go through the ParseContext's SharedContext to get the
ErrorContext in GeneralParser. For the main thread, it is the same context, and
off-thread we can use the ErrorContext member directly.

Depends on D153962

Comment 4

[Bryan Thrall [:bthrall]]

Attachment: Bug 1782569 - Use ErrorContext from BytecodeEmitter for ReportOutOfMemory() r=nbp

Depends on D153963

Comment 5

[Bryan Thrall [:bthrall]]

Attachment: Bug 1782569 - Use ErrorContext for ReportOutOfMemory() in FullParseHandler r=nbp

Depends on D153964

Comment 6

[Bryan Thrall [:bthrall]]

Attachment: Bug 1782569 - Add ErrorContext member to SharedContext r=nbp

We will use it with ReportOutOfMemory() calls and probably other places.

Specifically: FunctionBox::setAsmJSModule() calls ReportOutOfMemory().

Depends on D153965

Comment 7

[Bryan Thrall [:bthrall]]

Attachment: Bug 1782569 - Pass ErrorContext to ReportOutOfMemory in FunctionBox::setAsmJSModule() r=nbp

Depends on D153966

Comment 8

[Bryan Thrall [:bthrall]]

Attachment: Bug 1782569 - Pass ErrorContext to ReportOutOfMemory in CollectionPool::acquire() r=nbp

Depends on D153967

Comment 9

[Bryan Thrall [:bthrall]]

Attachment: Bug 1782569 - Pass ErrorContext to ReportOutOfMemory() in ObjLiteralWriter and ObjLiteralWriterBase r=nbp

Depends on D153968

Comment 10

[Bryan Thrall [:bthrall]]

Attachment: Bug 1782569 - Pass ErrorContext to ReportOutOfMemory in CompilationGCOutput::ensureReserved() r=nbp

Depends on D153969

Comment 11

[Bryan Thrall [:bthrall]]

Attachment: Bug 1782569 - Pass ErrorContext to ReportoutOfMemory for Stencil. r=nbp

To keep this patch simple to follow, I introduce some temporary functions
(initVector, initMap, setInitial, addDelazification) so I can plumb
ErrorContext through StencilXdr and ParseAtom in separate patches.

Depends on D153970

Comment 12

[Bryan Thrall [:bthrall]]

Attachment: Bug 1782569 - Add ErrorContext member to ASTSerializer r=nbp

ASTSerializer is not used in helper threads, so it doesn't need ErrorContext,
but it is better to reuse the existing MainThreadErrorContext in
reflect_parse() than to create a new one. Deciding which ErrorContext to use
should happen in few places, not everywhere.

Depends on D153971

Comment 13

[Bryan Thrall [:bthrall]]

Attachment: Bug 1782569 - Pass ErrorContext to ReportOutOfMemory() for CompilationAtomCache r=nbp

ParserBase::liftParserAtomToJSAtom() moved down from ParserSharedBase because
it seemed slightly easier than plumbing the ErrorContext member up to
ParserSharedBase.

CompilationStencil::instantiateSelfHostedAtoms() knows it isn't used by helper
threads because it is for self-hosted code.

CompilationStencil::instantiateStencilAfterPreparation() is instantiating the
stencil, so it happens on the main thread.

Depends on D154459

Comment 14

[Bryan Thrall [:bthrall]]

Attachment: Bug 1782569 - Pass ErrorContext to ReportOutOfMemory in Scope::maybeReportOOM() r=nbp

Depends on D154460

Comment 15

[Bryan Thrall [:bthrall]]

Attachment: Bug 1782569 - Pass ErrorContext to ReportOutOfMemory() when creating scope data r=nbp

Depends on D154461

Comment 16

[Bryan Thrall [:bthrall]]

Attachment: Bug 1782569 - Pass ErrorContext to ReportOutOfMemory() for ScopeStencil r=nbp

Depends on D154462

Comment 17

[Bryan Thrall [:bthrall]]

Attachment: Bug 1782569 - Pass ErrorContext to ReportOutOfMemory() for ParserAtom, ParserAtomsTable, ScriptSource, SharedImmutableScriptData r=nbp

Instantiating stencils happens on the main thread, so
InstantiateModuleStencil(), and InstantiateModuleStencilXDR() can safely use
MainThreadErrorContext.

Depends on D154463

Comment 18

[Bryan Thrall [:bthrall]]

Attachment: Bug 1782569 - Recover from OOM using ErrorContext r=nbp

If this is happening off the main thread, the errors are tracked in
ErrorContext, not JSContext.

Depends on D154464

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/294263a92e96
Extract JSContext::onOutOfMemory() r=nbp
https://hg.mozilla.org/integration/autoland/rev/c33f089db610
Add JS::ReportOutOfMemory(ErrorContext*) r=nbp
https://hg.mozilla.org/integration/autoland/rev/af724b3e2951
Use ErrorContext instead of JSContext for off-thread ReportOutOfMemory() r=nbp
https://hg.mozilla.org/integration/autoland/rev/b83b667d8244
Use ErrorContext from BytecodeEmitter for ReportOutOfMemory() r=nbp
https://hg.mozilla.org/integration/autoland/rev/6a9f97b3e66a
Use ErrorContext for ReportOutOfMemory() in FullParseHandler r=nbp
https://hg.mozilla.org/integration/autoland/rev/24737a6aae0a
Add ErrorContext member to SharedContext r=nbp
https://hg.mozilla.org/integration/autoland/rev/08d3b76abe02
Pass ErrorContext to ReportOutOfMemory in FunctionBox::setAsmJSModule() r=nbp
https://hg.mozilla.org/integration/autoland/rev/70436815ee6d
Pass ErrorContext to ReportOutOfMemory in CollectionPool::acquire() r=nbp
https://hg.mozilla.org/integration/autoland/rev/69dd93866f29
Pass ErrorContext to ReportOutOfMemory() in ObjLiteralWriter and ObjLiteralWriterBase r=nbp
https://hg.mozilla.org/integration/autoland/rev/9d377710076a
Pass ErrorContext to ReportOutOfMemory in CompilationGCOutput::ensureReserved() r=nbp
https://hg.mozilla.org/integration/autoland/rev/6aad32b63896
Pass ErrorContext to ReportoutOfMemory for Stencil. r=nbp
https://hg.mozilla.org/integration/autoland/rev/5577cc3982d1
Add ErrorContext member to ASTSerializer r=nbp
https://hg.mozilla.org/integration/autoland/rev/01541d4bf42e
Pass ErrorContext to ReportOutOfMemory() for CompilationAtomCache r=nbp
https://hg.mozilla.org/integration/autoland/rev/18c6e6eea130
Pass ErrorContext to ReportOutOfMemory in Scope::maybeReportOOM() r=nbp
https://hg.mozilla.org/integration/autoland/rev/bbe13d650d2c
Pass ErrorContext to ReportOutOfMemory() when creating scope data r=nbp
https://hg.mozilla.org/integration/autoland/rev/a05d45bff643
Pass ErrorContext to ReportOutOfMemory() for ScopeStencil r=nbp
https://hg.mozilla.org/integration/autoland/rev/dff2454b0433
Pass ErrorContext to ReportOutOfMemory() for ParserAtom, ParserAtomsTable, ScriptSource, SharedImmutableScriptData r=nbp
https://hg.mozilla.org/integration/autoland/rev/ef4121bbd9c8
Recover from OOM using ErrorContext r=nbp

Comment 20

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/294263a92e96
https://hg.mozilla.org/mozilla-central/rev/c33f089db610
https://hg.mozilla.org/mozilla-central/rev/af724b3e2951
https://hg.mozilla.org/mozilla-central/rev/b83b667d8244
https://hg.mozilla.org/mozilla-central/rev/6a9f97b3e66a
https://hg.mozilla.org/mozilla-central/rev/24737a6aae0a
https://hg.mozilla.org/mozilla-central/rev/08d3b76abe02
https://hg.mozilla.org/mozilla-central/rev/70436815ee6d
https://hg.mozilla.org/mozilla-central/rev/69dd93866f29
https://hg.mozilla.org/mozilla-central/rev/9d377710076a
https://hg.mozilla.org/mozilla-central/rev/6aad32b63896
https://hg.mozilla.org/mozilla-central/rev/5577cc3982d1
https://hg.mozilla.org/mozilla-central/rev/01541d4bf42e
https://hg.mozilla.org/mozilla-central/rev/18c6e6eea130
https://hg.mozilla.org/mozilla-central/rev/bbe13d650d2c
https://hg.mozilla.org/mozilla-central/rev/a05d45bff643
https://hg.mozilla.org/mozilla-central/rev/dff2454b0433
https://hg.mozilla.org/mozilla-central/rev/ef4121bbd9c8