1784054 - [Colorway Closet] Colorways modal elements can’t be reached with reduced browser height

Status: VERIFIED FIXED

(Toolkit Graveyard :: Notifications and Alerts, defect, P2)

Description

[Anca Soncutean, Desktop QA]

Attachment: screencast issue.gif

Found in

• Firefox 105.0a1

Affected versions

• Firefox 105.0a1

Affected platforms

• Windows 10
• macOS 12
• Ubuntu 20

Preconditions
In about:config set:

• "browser.theme.colorway-closet" to true
• "browser.tabs.firefox-view" to true

Steps to reproduce

1. Resize the browser width and height (ex. 500x450px)
2. Open Colorways modal from Fxview or from about:addons
3. Attempt to scroll the modal

Expected result

• The Colorways modal can be scrolled, all elements can be reached.

Actual result

• [ Ubuntu] - There is no scrollbar most of the elements on the modal can't be reached.
• [Windows/Mac] - There is a scrollbar, but not all the elements from the modal can be reached (see screencast).

Regression:

• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=1875b970dc64011b8a0b093ed432d0117d9758cb&tochange=dba4dc940ca9c180ac5ecc3011eb9761a3ca5026
• Bug regressor: 1783011

Comment 1

[Dão Gottwald [:dao]]

I don't think we'd consider this a regression, it just wasn't an issue at some point when not all parts of the modal were in place.

Comment 2

[Dão Gottwald [:dao]]

Also I think the real issue here is only with the height, not the width.

Comment 3

[Dão Gottwald [:dao]]

Could you please try this again in the latest Nightly now that bug 1783714 and bug 1784488 have been fixed?

Comment 4

[Anca Soncutean, Desktop QA]

Attachment: screencast issue.gif

Still reproducible with 105.0a1 (2022-08-16), tested with Win 10 and macOS 11. The modal keeps its initial size and there is no scrollbar.

Comment 5

[Dão Gottwald [:dao]]

It doesn't look like there's much the Colorway Closet modal code could do about this, it rather seems like a more fundamental problem that should be handled by SubDialog.jsm.

Comment 6

[Bernard Igiri]

Attachment: Bug 1784054 - Enable full height scrolling in Colorway Closet modal in small windows r=dao!

Enabled scrolling in Colorway Closet modal by turning on the sizeTo: "available" feature on the dialog.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:tspurway, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da1fd90bddbe
Enable full height scrolling in Colorway Closet modal in small windows r=dao

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/da1fd90bddbe

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:bigiri, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox105 to wontfix.

For more information, please visit auto_nag documentation.

Comment 11

[Anca Soncutean, Desktop QA]

Verified fixed with Fx 107.0a1 (2022-09-28) and Fx 106.0b5 on Windows 10, macOS 11 and Ubuntu 20.04.