1785016 - language selection for spell checking should account for the case where 10s of dictionaries are installed

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Dietmar Czekay]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:103.0) Gecko/20100101 Firefox/103.0

Steps to reproduce:

writing a message and click on send button on a debian sid system

Actual results:

tinstead of a dropdown button for selecting the language, all possible languages are listed in an endless list. the lower border of the dialog isn't visible

Expected results:

a dropdown list for selection

Comment 1

[Dietmar Czekay]

Attachment: ksnip_20220816-065748.png

Comment 2

[Martin Giger [:freaktechnik]]

We should add some kind of scrolling solution, either by making the list of checkboxes scroll inside a container with a max height, or by replacing the list with a multi select. This should allow us to avoid the dialog overflowing, especially since on some operating systems the dialog can't be freely resized.

Comment 3

[Martin Giger [:freaktechnik]]

Attachment: Bug 1785016 - Limit height of dictionary checklist in spellchecking dialog. r=aleca

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/966f7d0b5e4b
Limit height of dictionary checklist in spellchecking dialog. r=aleca

Comment 5

[Martin Giger [:freaktechnik]]

Comment on attachment 9290468 [details]
Bug 1785016 - Limit height of dictionary checklist in spellchecking dialog. r=aleca

[Approval Request Comment]
Regression caused by (bug #): Depending on how you look at it bug 1761221
User impact if declined: Spelling dialog might grow beyond reasonable window size.
Testing completed (on c-c, etc.): Tested on c-c, c-b.
Risk to taking this patch (and alternatives if risky): Pure style change in spelling dialog, so very limited scope of changes.

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9290468 [details]
Bug 1785016 - Limit height of dictionary checklist in spellchecking dialog. r=aleca

[Triage Comment]
Approved for esr102

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 102.2.1:
https://hg.mozilla.org/releases/comm-esr102/rev/468b5a5d1dfa