Closed
Bug 1786371
Opened 3 years ago
Closed 3 years ago
[Colorway Closet] Adjust modal’s max-width
Categories
(Firefox :: Theme, enhancement, P2)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
106 Branch
| Tracking | Status | |
|---|---|---|
| firefox106 | --- | fixed |
People
(Reporter: amy, Assigned: dao)
References
Details
(Whiteboard: [fidefe-colorway-closet] )
Attachments
(2 files)
Cropped modal window
Request from UX to adjust closet modal max-width to 800px.
|
Reporter | |
Updated•3 years ago
|
Blocks: colorway-closet
Whiteboard: [fidefe-colorway-closet]
|
||
Updated•3 years ago
|
|
|
Reporter | |
Updated•3 years ago
|
|
Assignee | |
Updated•3 years ago
|
Blocks: colorway-closet
|
|
Assignee | |
Comment 1•3 years ago
|
||
We'll want to translate this to an em value instead of using px.
|
|
Assignee | |
Updated•3 years ago
|
Severity: -- → N/A
Type: defect → enhancement
Points: --- → 1
Priority: -- → P2
|
|
Assignee | |
Comment 2•3 years ago
|
||
|
||
Updated•3 years ago
|
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/398d12cd601b
[Colorway Closet] Adjust modal’s max-width. r=amy
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox106:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
|
|
Reporter | |
Comment 5•3 years ago
|
||
This change may have caused a regression where the modal window is cropped. I think we should revert it, what do you think?
Flags: needinfo?(dao+bmo)
|
|
Assignee | |
Comment 6•3 years ago
|
||
(In reply to Amy Churchwell [:amy] from comment #5)
Created attachment 9291604 [details]
Cropped modal windowThis change may have caused a regression where the modal window is cropped. I think we should revert it, what do you think?
I don't think we should revert but I filed bug 1787523.
Flags: needinfo?(dao+bmo)
You need to log in
before you can comment on or make changes to this bug.
Description
•