Closed
Bug 1787523
Opened 3 years ago
Closed 3 years ago
[Colorway Closet] Further tweak initial width to deal with font size changes
Categories
(Firefox :: Theme, defect, P1)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
106 Branch
Tracking | Status | |
---|---|---|
firefox106 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
Details
(Whiteboard: [fidefe-colorway-closet] )
Attachments
(1 file)
Bug 1786858 made the modal's font size system-based, which is good but also means it's opened at a smaller size than before, and the degree differs across OSes. This is sort of fine in theory, as a smaller font size means we should need less space overall. But we're now way smaller than what we aimed for it seems. I'm going to propose 67em
which should amount to just over 800px on Windows where the default font size is 12px. It's going to be a bit less than 800px on macOS and slightly above on Linux. If we still run into problems with that, we may also have to adjust breakpoint values (which are px
based) or consider using 800px
instead of an em
value for the initial width.
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9a345de38916
[Colorway Closet] Further tweak initial width to deal with font size changes. r=amy
Comment 3•3 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox106:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
Comment 4•3 years ago
|
||
bugherder |
You need to log in
before you can comment on or make changes to this bug.
Description
•