178852 - flag selection is really bad for accessibility

Status: NEW

(Bugzilla :: Attachments & Requests, enhancement)

Description

[timeless]

there's a spec somewhere which says not to do this:
<a
href="something1">link</a>, <a href="something2">link</a>, <a
href="something3">link</a>, <a href="something4">link</a>, <a
href="something5">link</a>, <a href="something6">link</a>, <a
href="something7">link</a>, <a href="something8">link</a>.
The reason is that it's not good for screen readers or typeahead or voice input.

we're doing the equivalent:
... [{empty}|{minus}|{plus}]
... [{empty}|{minus}|{plus}]
... [{empty}|{minus}|{plus}]

instead we could do:

[no <review>|<review>-|<review>+]
[no <super review>|<super review>-|<super review>+]
[no <approval>|<approval>-|<approval>+]

[]s mean listbox
| is the list sep
{} means a literal symbol
<> mean some replacable string -- which i replaced.

I'd suggest abandoning -/+ and using 'granted' and 'rejected'. i think they
should always work.

Comment 1

[Dave Miller [:justdave]]

timeless, please clarify.  I have no clue what you're talking about here.  The
summary says "attachment status" but the description sounds like you're
describing flags, and I don't even follow where the list of links is you're
talking about...

Comment 2

[Frédéric Buclin]

*** Bug 240763 has been marked as a duplicate of this bug. ***

Comment 3

[timeless]

sorry, there are two flag classes flags for bugs and flags for attachments.

if i was talking about attachments, it'd be something like this: https://bugzilla.mozilla.org/show_bug.cgi?id=317544#a0

but i'm pretty sure i wasn't.

the problem is, imagine you're a screenreader and you see this:
Flags:   	
  	approval 		
  	approval3.2 		
  	blocking3.2 		
  	approval3.0 		
  	blocking3.0.6 		
  	approval2.22 		
  	blocking2.22.6 		
  	approval2.20 		
  	blocking2.20.7 		
  	documentation 		()
  	documentation3.2 		()
  	documentation3.0 		()
  	documentation2.22 		()
  	documentation2.20 		()
  	testcase 		()
  	needsinfo 		()

try reading that in any useful way. it's hard, it's painful. the screen reader advice is basically that you shouldn't have blobs of togglable stuff that run together and won't be easy to read.