1788777 - Move devtools network observer to a shared location available to both remote/ and devtools/

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P1)

Description

[Julian Descottes [:jdescottes]]

This is a simple code move bug. We need to find a location in tree which will always be included when devtools and/or remote are built. This should be done after migrating the common JS modules to ESM.

devtools/shared/ could be an option. As far as I can tell, only devtools/client can be excluded from builds easily. To be verifed. From an external point of view devtools/shared makes some sense, but from a DevTools point of view, this folder is usually for modules used both by the client and the server. There's also the question of maintenance, developers working on those modules should be aware that it's used outside of devtools.

I think all of remote/ can be excluded, so we should probably not put the module there.

Maybe a non-devtools/non-remote folder could also be an option.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Please note that we do not necessarily have to find a folder that can be used to share this observer module. We could handle the file similarly to httpd.js and could instruct the build process to copy the file into our folder structure.

That way it doesn't matter if DevTools is enabled or not for the build process.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

We should only make sure that good documentation gets added in the devtools folder which explains that this module is shared.

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1788777 - [devtools] Group all network-observer related modules in a single folder

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02c859d135b7
[devtools] Group all network-observer related modules in a single folder r=ochameau,Sasha

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/02c859d135b7