1789186 - High frequency browser/components/newtab/test/browser/browser_aboutwelcome_upgrade_multistage_mr.js | single tracking bug

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Treeherder Bug Filer]

Filed by: ccozmuta [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=389471325&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/cQEt5pUXRX611zKtVCJaaQ/runs/0/artifacts/public/logs/live_backing.log

---

[task 2022-09-05T05:06:52.134Z] 05:06:52     INFO - TEST-PASS | browser/components/newtab/test/browser/browser_aboutwelcome_upgrade_multistage_mr.js | Should not render main.PIN_FIREFOX - true == true - 
[task 2022-09-05T05:06:52.134Z] 05:06:52     INFO - Buffered messages logged at 05:05:24
[task 2022-09-05T05:06:52.134Z] 05:06:52     INFO - TEST-PASS | browser/components/newtab/test/browser/browser_aboutwelcome_upgrade_multistage_mr.js | Should not render main.action-checkbox - true == true - 
[task 2022-09-05T05:06:52.134Z] 05:06:52     INFO - Buffered messages logged at 05:05:25
[task 2022-09-05T05:06:52.134Z] 05:06:52     INFO - TEST-PASS | browser/components/newtab/test/browser/browser_aboutwelcome_upgrade_multistage_mr.js | homepage pref should be default - true == true - 
[task 2022-09-05T05:06:52.134Z] 05:06:52     INFO - TEST-PASS | browser/components/newtab/test/browser/browser_aboutwelcome_upgrade_multistage_mr.js | newtab pref should be default - true == true - 
[task 2022-09-05T05:06:52.134Z] 05:06:52     INFO - Leaving test bound test_aboutwelcome_upgrade_mr_prefs_off
[task 2022-09-05T05:06:52.134Z] 05:06:52     INFO - Entering test bound test_aboutwelcome_upgrade_mr_prefs_non_default_unchecked
[task 2022-09-05T05:06:52.138Z] 05:06:52     INFO - Buffered messages logged at 05:05:26
[task 2022-09-05T05:06:52.139Z] 05:06:52     INFO - Console message: Invalid chrome URI (need path): chrome://browser/
[task 2022-09-05T05:06:52.139Z] 05:06:52     INFO - TEST-PASS | browser/components/newtab/test/browser/browser_aboutwelcome_upgrade_multistage_mr.js | Should not render main.PIN_FIREFOX - true == true - 
[task 2022-09-05T05:06:52.140Z] 05:06:52     INFO - Buffered messages logged at 05:05:29
[task 2022-09-05T05:06:52.143Z] 05:06:52     INFO - TEST-PASS | browser/components/newtab/test/browser/browser_aboutwelcome_upgrade_multistage_mr.js | homepage pref should have a user value - true == true - 
[task 2022-09-05T05:06:52.144Z] 05:06:52     INFO - TEST-PASS | browser/components/newtab/test/browser/browser_aboutwelcome_upgrade_multistage_mr.js | newtab pref should have a user value - true == true - 
[task 2022-09-05T05:06:52.146Z] 05:06:52     INFO - Leaving test bound test_aboutwelcome_upgrade_mr_prefs_non_default_unchecked
[task 2022-09-05T05:06:52.155Z] 05:06:52     INFO - Entering test bound test_aboutwelcome_upgrade_mr_prefs_non_default_checked
[task 2022-09-05T05:06:52.156Z] 05:06:52     INFO - Buffered messages finished
[task 2022-09-05T05:06:52.157Z] 05:06:52     INFO - TEST-UNEXPECTED-FAIL | browser/components/newtab/test/browser/browser_aboutwelcome_upgrade_multistage_mr.js | Test timed out - 
[task 2022-09-05T05:06:52.158Z] 05:06:52     INFO - Not taking screenshot here: see the one that was previously logged
[task 2022-09-05T05:06:52.159Z] 05:06:52     INFO - TEST-UNEXPECTED-FAIL | browser/components/newtab/test/browser/browser_aboutwelcome_upgrade_multistage_mr.js | Uncaught exception received from previously timed out test - subdialog-loaded observer not removed before the end of test
[task 2022-09-05T05:06:52.163Z] 05:06:52     INFO - Entering test bound test_aboutwelcome_upgrade_mr_private_pin
[task 2022-09-05T05:06:52.164Z] 05:06:52     INFO - Not taking screenshot here: see the one that was previously logged
[task 2022-09-05T05:06:52.171Z] 05:06:52     INFO - TEST-UNEXPECTED-FAIL | browser/components/newtab/test/browser/browser_aboutwelcome_upgrade_multistage_mr.js | Uncaught exception received from previously timed out test - at chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_aboutwelcome_upgrade_multistage_mr.js:259 - TypeError: OnboardingMessageProvider._doesAppNeedPin.resolves is not a function
[task 2022-09-05T05:06:52.172Z] 05:06:52     INFO - Stack trace:
[task 2022-09-05T05:06:52.173Z] 05:06:52     INFO - test_aboutwelcome_upgrade_mr_private_pin@chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_aboutwelcome_upgrade_multistage_mr.js:259:45
[task 2022-09-05T05:06:52.174Z] 05:06:52     INFO - handleTask@chrome://mochikit/content/browser-test.js:1028:26
[task 2022-09-05T05:06:52.174Z] 05:06:52     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1100:18
[task 2022-09-05T05:06:52.175Z] 05:06:52     INFO - ensureDOMPromiseRejectionsProcessed@resource://testing-common/PromiseTestUtils.jsm:119:17
[task 2022-09-05T05:06:52.175Z] 05:06:52     INFO - nextTest@chrome://mochikit/content/browser-test.js:662:29
[task 2022-09-05T05:06:52.179Z] 05:06:52     INFO - Entering test bound test_aboutwelcome_upgrade_mr_private_pin_get_started
[task 2022-09-05T05:06:52.180Z] 05:06:52     INFO - Not taking screenshot here: see the one that was previously logged
[task 2022-09-05T05:06:52.182Z] 05:06:52     INFO - TEST-UNEXPECTED-FAIL | browser/components/newtab/test/browser/browser_aboutwelcome_upgrade_multistage_mr.js | Uncaught exception received from previously timed out test - at chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_aboutwelcome_upgrade_multistage_mr.js:292 - TypeError: OnboardingMessageProvider._doesAppNeedPin.resolves is not a function
[task 2022-09-05T05:06:52.183Z] 05:06:52     INFO - Stack trace:
[task 2022-09-05T05:06:52.183Z] 05:06:52     INFO - test_aboutwelcome_upgrade_mr_private_pin_get_started@chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_aboutwelcome_upgrade_multistage_mr.js:292:45
[task 2022-09-05T05:06:52.183Z] 05:06:52     INFO - handleTask@chrome://mochikit/content/browser-test.js:1028:26
[task 2022-09-05T05:06:52.183Z] 05:06:52     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1100:18
[task 2022-09-05T05:06:52.183Z] 05:06:52     INFO - ensureDOMPromiseRejectionsProcessed@resource://testing-common/PromiseTestUtils.jsm:119:17
[task 2022-09-05T05:06:52.183Z] 05:06:52     INFO - nextTest@chrome://mochikit/content/browser-test.js:662:29
[task 2022-09-05T05:06:52.184Z] 05:06:52     INFO - Entering test bound test_aboutwelcome_upgrade_mr_private_pin_not_needed
[task 2022-09-05T05:06:52.187Z] 05:06:52     INFO - Not taking screenshot here: see the one that was previously logged
[task 2022-09-05T05:06:52.189Z] 05:06:52     INFO - TEST-UNEXPECTED-FAIL | browser/components/newtab/test/browser/browser_aboutwelcome_upgrade_multistage_mr.js | Uncaught exception received from previously timed out test - at chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_aboutwelcome_upgrade_multistage_mr.js:315 - TypeError: OnboardingMessageProvider._doesAppNeedPin.resolves is not a function
[task 2022-09-05T05:06:52.189Z] 05:06:52     INFO - Stack trace:
[task 2022-09-05T05:06:52.189Z] 05:06:52     INFO - test_aboutwelcome_upgrade_mr_private_pin_not_needed@chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_aboutwelcome_upgrade_multistage_mr.js:315:6
[task 2022-09-05T05:06:52.189Z] 05:06:52     INFO - handleTask@chrome://mochikit/content/browser-test.js:1028:26
[task 2022-09-05T05:06:52.189Z] 05:06:52     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1100:18
[task 2022-09-05T05:06:52.190Z] 05:06:52     INFO - ensureDOMPromiseRejectionsProcessed@resource://testing-common/PromiseTestUtils.jsm:119:17
[task 2022-09-05T05:06:52.190Z] 05:06:52     INFO - nextTest@chrome://mochikit/content/browser-test.js:662:29
[task 2022-09-05T05:06:52.190Z] 05:06:52     INFO - Entering test bound test_aboutwelcome_upgrade_mr_pin_not_needed_default_needed
[task 2022-09-05T05:06:52.191Z] 05:06:52     INFO - Not taking screenshot here: see the one that was previously logged
[task 2022-09-05T05:06:52.196Z] 05:06:52     INFO - TEST-UNEXPECTED-FAIL | browser/components/newtab/test/browser/browser_aboutwelcome_upgrade_multistage_mr.js | Uncaught exception received from previously timed out test - at chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_aboutwelcome_upgrade_multistage_mr.js:339 - TypeError: OnboardingMessageProvider._doesAppNeedPin.resolves is not a function
[task 2022-09-05T05:06:52.196Z] 05:06:52     INFO - Stack trace:
[task 2022-09-05T05:06:52.196Z] 05:06:52     INFO - test_aboutwelcome_upgrade_mr_pin_not_needed_default_needed@chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_aboutwelcome_upgrade_multistage_mr.js:339:47
[task 2022-09-05T05:06:52.196Z] 05:06:52     INFO - handleTask@chrome://mochikit/content/browser-test.js:1028:26
[task 2022-09-05T05:06:52.196Z] 05:06:52     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1100:18
[task 2022-09-05T05:06:52.196Z] 05:06:52     INFO - ensureDOMPromiseRejectionsProcessed@resource://testing-common/PromiseTestUtils.jsm:119:17
[task 2022-09-05T05:06:52.196Z] 05:06:52     INFO - nextTest@chrome://mochikit/content/browser-test.js:662:29
[task 2022-09-05T05:06:52.197Z] 05:06:52     INFO - Entering test bound test_aboutwelcome_upgrade_show_firefox_view
[task 2022-09-05T05:06:52.198Z] 05:06:52     INFO - GECKO(1624) | [Child 1788: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 7fd537643800 == 3 [pid = 1788] [id = 55]
[task 2022-09-05T05:06:52.198Z] 05:06:52     INFO - GECKO(1624) | [Child 1788: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 5 (7fd536c72260) [pid = 1788] [serial = 170] [outer = 0]
[task 2022-09-05T05:06:52.199Z] 05:06:52     INFO - GECKO(1624) | [Child 1788: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 6 (7fd537643c00) [pid = 1788] [serial = 171] [outer = 7fd536c72260]
[task 2022-09-05T05:06:52.200Z] 05:06:52     INFO - GECKO(1624) | [Child 1788, Main Thread] WARNING: '!CanHandleWith(aPresContext)', file /builds/worker/checkouts/gecko/dom/events/IMEStateManager.cpp:498
[task 2022-09-05T05:06:52.202Z] 05:06:52     INFO - GECKO(1624) | [Child 1788: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 7 (7fd537645400) [pid = 1788] [serial = 172] [outer = 7fd536c72260]

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:dmosedale, since you are the author of the regressor, bug 1789008, could you take a look?

For more information, please visit auto_nag documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1789008

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

I have some code locally that should fix a race that I hope will make this less frequent.

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: WIP: Bug 1789186 - Avoid future race in _showUpgradeDialog

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

The above patch will only be useful in combination with other patches we're likely to need to fix this bug.

Comment 6

[Intermittent Failures Robot]

18 failures in 672 pushes (0.027 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 16
• mozilla-central: 2

Platform and build breakdown:

• linux1804-64-qr: 15
  • debug: 15
• windows10-64-2004-qr: 1
  • debug: 1
• macosx1015-64-qr: 2
  • debug: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1789186&startday=2022-09-06&endday=2022-09-06&tree=all

Comment 7

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: WIP: Bug 1789186 - tab-modal onboarding logging/dev infra

Comment 8

[Intermittent Failures Robot]

24 failures in 827 pushes (0.029 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 19
• mozilla-central: 5

Platform and build breakdown:

• linux1804-64-qr: 19
  • debug: 19
• linux1804-64-tsan-qr: 3
  • opt: 3
• windows10-32-2004-qr: 1
  • debug: 1
• linux1804-64-asan-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1789186&startday=2022-09-07&endday=2022-09-07&tree=all

Comment 9

[Intermittent Failures Robot]

24 failures in 719 pushes (0.033 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 24

Platform and build breakdown:

• linux1804-64-qr: 20
  • debug: 20
• windows10-32-2004-qr: 1
  • debug: 1
• linux1804-64-asan-qr: 1
  • opt: 1
• windows10-64-2004-qr: 1
  • debug: 1
• macosx1015-64-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1789186&startday=2022-09-08&endday=2022-09-08&tree=all

Comment 10

[Intermittent Failures Robot]

34 failures in 670 pushes (0.051 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 29
• mozilla-central: 4
• try: 1

Platform and build breakdown:

• linux1804-64-qr: 26
  • debug: 26
• linux1804-64-tsan-qr: 5
  • opt: 5
• linux1804-64-asan-qr: 2
  • opt: 2
• windows10-64-2004-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1789186&startday=2022-09-09&endday=2022-09-09&tree=all

Comment 11

[Intermittent Failures Robot]

121 failures in 3616 pushes (0.033 failures/push) were associated with this bug in the last 7 days.

This is the #5 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 106
• mozilla-central: 14
• try: 1

Platform and build breakdown:

• linux1804-64-qr: 99
  • debug: 98
  • opt: 1
• windows10-64-2004-qr: 3
  • debug: 3
• macosx1015-64-qr: 5
  • debug: 3
  • opt: 2
• linux1804-64-tsan-qr: 8
  • opt: 8
• windows10-32-2004-qr: 2
  • debug: 2
• linux1804-64-asan-qr: 4
  • opt: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1789186&startday=2022-09-05&endday=2022-09-11&tree=all

Comment 12

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Bug 1789186 - Fix _showUpgradeDialog race, r?Mardak

Comment 13

[Intermittent Failures Robot]

19 failures in 647 pushes (0.029 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 18
• mozilla-central: 1

Platform and build breakdown:

• linux1804-64-qr: 16
  • debug: 16
• windows10-64-2004-qr: 2
  • debug: 2
• linux1804-64-asan-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1789186&startday=2022-09-12&endday=2022-09-12&tree=all

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6bd72226738a
Fix _showUpgradeDialog race, r=Mardak

Comment 15

[Dan Mosedale (:dmosedale, :dmose)]

Once this merges to central, it would be great to verify that the tab-modal existing user onboarding continues to automatically open correctly, both in the more generic case, and by running, say, 2 or 3 of the tests mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=1789549#c4.

Comment 16

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/6bd72226738a

Comment 17

[Intermittent Failures Robot]

32 failures in 3023 pushes (0.011 failures/push) were associated with this bug in the last 7 days.

This is the #21 most frequent failure this week.

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. **

Repository breakdown:

• autoland: 30
• mozilla-central: 2

Platform and build breakdown:

• linux1804-64-qr: 28
  • debug: 28
• windows10-64-2004-qr: 2
  • debug: 2
• linux1804-64-asan-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1789186&startday=2022-09-12&endday=2022-09-18&tree=all

Comment 18

[Marius Coman [:mcoman], Ecosystem QA]

This defect was part of the testing performed in the Nightly checkpoint phase for which we sent a GREEN checkpoint status. Considering this I am marking this issue as Verified.

Comment 20

[Intermittent Failures Robot]

2 failures in 3510 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 2

Platform and build breakdown:

• linux1804-64-qr: 2
  • debug: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1789186&startday=2022-12-05&endday=2022-12-11&tree=all