1790020 - Hook up urlbar result menu with suggest telemetry or event telemetry

Status: RESOLVED FIXED

(Firefox :: Address Bar, task)

Comment 1

[Dão Gottwald [:dao]]

From https://phabricator.services.mozilla.com/D166578#inline-919251:

This bypasses telemetry that's normally recorded when the user picks a Suggest help button. In general it bypasses any handling that's currently done by going through UrlbarInput.pickResult(). I think you'll need to do something like this.input.pickResult(result, event, menuitem), but engagement telemetry isn't currently prepared to handle command events and menu item elements.

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 1790020 - Hook up urlbar result menu with telementry. r=mak

Comment 3

[Dão Gottwald [:dao]]

(In reply to Dão Gottwald [::dao] from comment #1)

This bypasses telemetry that's normally recorded when the user picks a Suggest help button. In general it bypasses any handling that's currently done by going through UrlbarInput.pickResult(). I think you'll need to do something like this.input.pickResult(result, event, menuitem), but engagement telemetry isn't currently prepared to handle command events and menu item elements.

pickResult is already quite complex, so I'm not sure expanding it to handle elements that aren't even selected view elements is a good idea. UrlbarInput currently doesn't deal with the result menu at all. My impression is that there's not much of an existing path I could directly use, so it would really just add complexity. I put up a straw-man patch that makes the view invoke the controller's telemetry stuff directly instead of going through pickResult. Does this seem reasonable?

Comment 4

[Drew Willcoxon :adw]

You're right. Your patch is reasonable and seems a lot better than going through pickResult() after all, thanks.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7822e311e0c
Hook up urlbar result menu with telementry. r=mak

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0734dc2a0dac
Backed out changeset e7822e311e0c for causing mochitests failures in browser/components/urlbar/tests/browser-tips/browser_searchTips_interaction.js. CLOSED TREE

Comment 7

[Serban Stanca [:SerbanS]]

Backed out for causing mochitests failures in browser/components/urlbar/tests/browser-tips/browser_searchTips_interaction.js.

• Backout link
• Push with failures 1 ---> Retriggers and backfills
• Failure Log bc14
• Failure Log bc15
• Failure line bc14: TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser-tips/browser_searchTips_interaction.js | object in event urlbar#engagement#click must match. - "click" matches "enter" - {"filename":"resource://testing-common/TelemetryTestUtils.sys.mjs","name":"assertEvents","sourceId":602,"lineNumber":272,"columnNumber":16,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":{"filename":"chrome://mochitests/content/browser/browser/compon
• Failure line bc15: TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_urlbar.js | Test timed out -

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fcc4aae881d7
Hook up urlbar result menu with telementry. r=mak

Comment 9

[Cristina Horotan [:chorotan]]

Backed out changeset fcc4aae881d7 (bug 1790020) for causing bc failures at browser_ext_urlbar.js

Backout: https://hg.mozilla.org/integration/autoland/rev/9973259e69e777523ef59055a346dd439efe6f62

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=SCDhKXW1T5KCMBtC2i8ZNg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=fcc4aae881d7ece72c22ed3a3aedf2403fae5ccb

Failure log: https://treeherder.mozilla.org/logviewer?job_id=408375038&repo=autoland&lineNumber=6523

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e06f5ee4dd4
Hook up urlbar result menu with telementry. r=mak

Comment 11

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/4e06f5ee4dd4