Closed Bug 1790050 Opened 4 years ago Closed 4 years ago

Perma TEST-UNEXPECTED-FAIL | layout/base/tests/chrome/test_color_scheme_browser.xhtml | dynamic-test: remote should be light - got "dark", expected "light" when Gecko merges to Beta on 2022-09-19

Categories

(Core :: Layout, defect, P1)

Product:
Core
Component:
Layout
Type:
defect
Points:
1

Tracking

()

Status:
VERIFIED FIXED
Milestone:
106 Branch
Tracking Flags:
Tracking Status
firefox-esr91 --- unaffected
firefox-esr102 --- unaffected
firefox104 --- unaffected
firefox105 --- unaffected
firefox106 + verified

People

(Reporter: apavel, Assigned: dao)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [fidefe-colorway-closet])

Attachments

(1 file)

Bug 1790050 - Skip test_browser_color_scheme_dynamic_system in DevEdition. r=emilio
48 bytes, text/x-phabricator-request
Details | Review

Central as Beta simulation
How to run these simulations
Failure log

[task 2022-09-09T12:33:55.449Z] 12:33:55     INFO - TEST-START | layout/base/tests/chrome/test_color_scheme_browser.xhtml
[task 2022-09-09T12:33:55.837Z] 12:33:55     INFO - GECKO(5484) | WARNING: content window passed to PrivateBrowsingUtils.isWindowPrivate. Use isContentWindowPrivate instead (but only for frame scripts).
[task 2022-09-09T12:33:55.840Z] 12:33:55     INFO - GECKO(5484) | pbu_isWindowPrivate@resource://gre/modules/PrivateBrowsingUtils.jsm:25:11
[task 2022-09-09T12:33:55.841Z] 12:33:55     INFO - GECKO(5484) | isBrowserPrivate@resource://gre/modules/PrivateBrowsingUtils.jsm:45:19
[task 2022-09-09T12:33:55.844Z] 12:33:55     INFO - GECKO(5484) | loadURI@resource://gre/modules/RemoteWebNavigation.jsm:86:56
[task 2022-09-09T12:33:55.845Z] 12:33:55     INFO - GECKO(5484) | loadURI/<@chrome://global/content/elements/browser-custom-element.js:811:28
[task 2022-09-09T12:33:55.846Z] 12:33:55     INFO - GECKO(5484) | _wrapURIChangeCall@chrome://global/content/elements/browser-custom-element.js:740:9
[task 2022-09-09T12:33:55.846Z] 12:33:55     INFO - GECKO(5484) | loadURI@chrome://global/content/elements/browser-custom-element.js:810:12
[task 2022-09-09T12:33:55.848Z] 12:33:55     INFO - GECKO(5484) | ensureBrowsersLoaded@chrome://mochitests/content/chrome/layout/base/tests/chrome/test_color_scheme_browser.xhtml:48:13
[task 2022-09-09T12:33:55.849Z] 12:33:55     INFO - GECKO(5484) | add_task/nextTick/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:2109:34
[task 2022-09-09T12:33:55.850Z] 12:33:55     INFO - GECKO(5484) | nextTick@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:2141:11
[task 2022-09-09T12:33:55.888Z] 12:33:55     INFO - GECKO(5484) | WARNING: content window passed to PrivateBrowsingUtils.isWindowPrivate. Use isContentWindowPrivate instead (but only for frame scripts).
[task 2022-09-09T12:33:55.889Z] 12:33:55     INFO - GECKO(5484) | pbu_isWindowPrivate@resource://gre/modules/PrivateBrowsingUtils.jsm:25:11
[task 2022-09-09T12:33:55.890Z] 12:33:55     INFO - GECKO(5484) | isBrowserPrivate@resource://gre/modules/PrivateBrowsingUtils.jsm:45:19
[task 2022-09-09T12:33:55.891Z] 12:33:55     INFO - GECKO(5484) | loadURI@resource://gre/modules/RemoteWebNavigation.jsm:86:56
[task 2022-09-09T12:33:55.892Z] 12:33:55     INFO - GECKO(5484) | loadURI/<@chrome://global/content/elements/browser-custom-element.js:811:28
[task 2022-09-09T12:33:55.893Z] 12:33:55     INFO - GECKO(5484) | _wrapURIChangeCall@chrome://global/content/elements/browser-custom-element.js:740:9
[task 2022-09-09T12:33:55.895Z] 12:33:55     INFO - GECKO(5484) | loadURI@chrome://global/content/elements/browser-custom-element.js:810:12
[task 2022-09-09T12:33:55.896Z] 12:33:55     INFO - GECKO(5484) | ensureBrowsersLoaded@chrome://mochitests/content/chrome/layout/base/tests/chrome/test_color_scheme_browser.xhtml:48:13
[task 2022-09-09T12:33:55.995Z] 12:33:55     INFO - GECKO(5484) | WARNING: content window passed to PrivateBrowsingUtils.isWindowPrivate. Use isContentWindowPrivate instead (but only for frame scripts).
[task 2022-09-09T12:33:55.996Z] 12:33:55     INFO - GECKO(5484) | pbu_isWindowPrivate@resource://gre/modules/PrivateBrowsingUtils.jsm:25:11
[task 2022-09-09T12:33:55.996Z] 12:33:55     INFO - GECKO(5484) | isBrowserPrivate@resource://gre/modules/PrivateBrowsingUtils.jsm:45:19
[task 2022-09-09T12:33:55.998Z] 12:33:55     INFO - GECKO(5484) | loadURI@resource://gre/modules/RemoteWebNavigation.jsm:86:56
[task 2022-09-09T12:33:56.001Z] 12:33:56     INFO - GECKO(5484) | loadURI/<@chrome://global/content/elements/browser-custom-element.js:811:28
[task 2022-09-09T12:33:56.003Z] 12:33:56     INFO - GECKO(5484) | _wrapURIChangeCall@chrome://global/content/elements/browser-custom-element.js:740:9
[task 2022-09-09T12:33:56.004Z] 12:33:56     INFO - GECKO(5484) | loadURI@chrome://global/content/elements/browser-custom-element.js:810:12
[task 2022-09-09T12:33:56.004Z] 12:33:56     INFO - GECKO(5484) | ensureBrowsersLoaded@chrome://mochitests/content/chrome/layout/base/tests/chrome/test_color_scheme_browser.xhtml:48:13
[task 2022-09-09T12:33:56.852Z] 12:33:56     INFO - TEST-INFO | started process screentopng
[task 2022-09-09T12:33:57.138Z] 12:33:57     INFO - TEST-INFO | screentopng: exit 0
[task 2022-09-09T12:33:57.139Z] 12:33:57     INFO - Buffered messages logged at 12:33:55
[task 2022-09-09T12:33:57.139Z] 12:33:57     INFO - add_task | Entering ensureBrowsersLoaded
[task 2022-09-09T12:33:57.139Z] 12:33:57     INFO - Buffered messages logged at 12:33:56
[task 2022-09-09T12:33:57.139Z] 12:33:57     INFO - add_task | Leaving ensureBrowsersLoaded
[task 2022-09-09T12:33:57.139Z] 12:33:57     INFO - add_task | Entering test_browser_color_scheme
[task 2022-09-09T12:33:57.139Z] 12:33:57     INFO - TEST-PASS | layout/base/tests/chrome/test_color_scheme_browser.xhtml | dynamic-test: remote should be dark 
[task 2022-09-09T12:33:57.139Z] 12:33:57     INFO - TEST-PASS | layout/base/tests/chrome/test_color_scheme_browser.xhtml | dynamic-test: nonremote should be dark 
[task 2022-09-09T12:33:57.139Z] 12:33:57     INFO - TEST-PASS | layout/base/tests/chrome/test_color_scheme_browser.xhtml | light: remote should be light 
[task 2022-09-09T12:33:57.140Z] 12:33:57     INFO - TEST-PASS | layout/base/tests/chrome/test_color_scheme_browser.xhtml | light: nonremote should be light 
[task 2022-09-09T12:33:57.140Z] 12:33:57     INFO - TEST-PASS | layout/base/tests/chrome/test_color_scheme_browser.xhtml | dark: remote should be dark 
[task 2022-09-09T12:33:57.141Z] 12:33:57     INFO - TEST-PASS | layout/base/tests/chrome/test_color_scheme_browser.xhtml | dark: nonremote should be dark 
[task 2022-09-09T12:33:57.141Z] 12:33:57     INFO - add_task | Leaving test_browser_color_scheme
[task 2022-09-09T12:33:57.142Z] 12:33:57     INFO - add_task | Entering test_browser_color_scheme_dynamic_style
[task 2022-09-09T12:33:57.145Z] 12:33:57     INFO - TEST-PASS | layout/base/tests/chrome/test_color_scheme_browser.xhtml | dynamic-test: remote should be light 
[task 2022-09-09T12:33:57.146Z] 12:33:57     INFO - TEST-PASS | layout/base/tests/chrome/test_color_scheme_browser.xhtml | dynamic-test: nonremote should be light 
[task 2022-09-09T12:33:57.148Z] 12:33:57     INFO - TEST-PASS | layout/base/tests/chrome/test_color_scheme_browser.xhtml | dynamic-test: remote should be dark 
[task 2022-09-09T12:33:57.155Z] 12:33:57     INFO - TEST-PASS | layout/base/tests/chrome/test_color_scheme_browser.xhtml | dynamic-test: nonremote should be dark 
[task 2022-09-09T12:33:57.157Z] 12:33:57     INFO - add_task | Leaving test_browser_color_scheme_dynamic_style
[task 2022-09-09T12:33:57.158Z] 12:33:57     INFO - add_task | Entering test_browser_color_scheme_dynamic_system
[task 2022-09-09T12:33:57.159Z] 12:33:57     INFO - TEST-PASS | layout/base/tests/chrome/test_color_scheme_browser.xhtml | dynamic-test: remote should be dark 
[task 2022-09-09T12:33:57.160Z] 12:33:57     INFO - TEST-PASS | layout/base/tests/chrome/test_color_scheme_browser.xhtml | dynamic-test: nonremote should be dark 
[task 2022-09-09T12:33:57.160Z] 12:33:57     INFO - Buffered messages finished
[task 2022-09-09T12:33:57.162Z] 12:33:57     INFO - TEST-UNEXPECTED-FAIL | layout/base/tests/chrome/test_color_scheme_browser.xhtml | dynamic-test: remote should be light - got "dark", expected "light"
[task 2022-09-09T12:33:57.162Z] 12:33:57     INFO - SimpleTest.is@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:497:14
[task 2022-09-09T12:33:57.162Z] 12:33:57     INFO - testElement@chrome://mochitests/content/chrome/layout/base/tests/chrome/test_color_scheme_browser.xhtml:67:13
[task 2022-09-09T12:33:57.163Z] 12:33:57     INFO - Not taking screenshot here: see the one that was previously logged
[task 2022-09-09T12:33:57.164Z] 12:33:57     INFO - TEST-UNEXPECTED-FAIL | layout/base/tests/chrome/test_color_scheme_browser.xhtml | dynamic-test: nonremote should be light - got "dark", expected "light"
[task 2022-09-09T12:33:57.165Z] 12:33:57     INFO - SimpleTest.is@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:497:14
[task 2022-09-09T12:33:57.166Z] 12:33:57     INFO - testElement@chrome://mochitests/content/chrome/layout/base/tests/chrome/test_color_scheme_browser.xhtml:67:13
[task 2022-09-09T12:33:57.167Z] 12:33:57     INFO - add_task | Leaving test_browser_color_scheme_dynamic_system
[task 2022-09-09T12:33:57.167Z] 12:33:57     INFO - GECKO(5484) | MEMORY STAT | vsize 11717MB | residentFast 442MB | heapAllocated 203MB
[task 2022-09-09T12:33:57.168Z] 12:33:57     INFO - TEST-OK | layout/base/tests/chrome/test_color_scheme_browser.xhtml | took 1618ms

Hi Dão, I believe this is a regression of bug 1788822, can you please take a look?

Flags: needinfo?(dao+bmo)
Summary: Perma → Perma TEST-UNEXPECTED-FAIL | layout/base/tests/chrome/test_color_scheme_browser.xhtml | dynamic-test: remote should be light - got "dark", expected "light" when Gecko merges to Beta on 2022-09-19

Hm, I don't understand how beta simulation would make a difference for this test. Emilio, is some of the color-scheme work you done recently behind a Nightly ifdef? Do you have other ideas?

Flags: needinfo?(dao+bmo) → needinfo?(emilio)

Yes, the default theme used by DevEdition is dark. So this combination of prefs before your change meant "system" and forced dark mode: https://searchfox.org/mozilla-central/rev/31368c7795f44b7a15531d6c5e52dc97f82cf2d5/layout/base/tests/chrome/test_color_scheme_browser.xhtml#94

But now they remain dark because of the theme, does that help?

Flags: needinfo?(emilio) → needinfo?(dao+bmo)

(In reply to Emilio Cobos Álvarez (:emilio) from comment #2)

Yes, the default theme used by DevEdition is dark. So this combination of prefs before your change meant "system" and forced dark mode: https://searchfox.org/mozilla-central/rev/31368c7795f44b7a15531d6c5e52dc97f82cf2d5/layout/base/tests/chrome/test_color_scheme_browser.xhtml#94

But now they remain dark because of the theme, does that help?

Yes, thanks. I forgot that devedition is still a thing. :(

Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Flags: needinfo?(dao+bmo)
Blocks: colorway-closet
Severity: -- → N/A
Points: --- → 1
Priority: -- → P1
Whiteboard: [fidefe-colorway-closet]
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/421c0a5ed7b3 Skip test_browser_color_scheme_dynamic_system in DevEdition. r=emilio

https://hg.mozilla.org/mozilla-central/rev/421c0a5ed7b3

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox106: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch

Fix verified in today's central as early beta simulation.

Status: RESOLVED → VERIFIED
status-firefox106: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: