Closed Bug 179056 Opened 19 years ago Closed 15 years ago

"Check for new message every" stops after hibernate

Categories

(MailNews Core :: Backend, defect)

x86
Windows 2000
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: claudio, Assigned: emk)

References

Details

(Keywords: fixed1.8.0.4, fixed1.8.1)

Attachments

(7 files, 3 obsolete files)

When resuming Windows from hibernate (on a laptop, HP Omnibook xe4500) Mozilla
Mail does not check my IMAP account every 2 minutes as it does normally. I need
to manually check mail one time and then the feature began to work properly.
Using Mozilla 1.2b/en on a Windows 2000 SP3
QA Contact: gayatri → huang
This still happens on Thunderbird 0.3, Win2k SP4.
Hi
Exactly the same on
winxp sp1 + hotfixes
mozilla 1.6
this is really annoying problem :(
I also have this problem on a win2k with Mozilla 1.7b using POP servers.
I can confirm this with

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.2) Gecko/20040803

on a Win2K laptop (2 POP servers).
Product: MailNews → Core
bug 275727, bug 271183 and bug 179056 are dups. Can someone dup them and confirm
one?
*** Bug 271183 has been marked as a duplicate of this bug. ***
This also affects Firefox and, I expect the browser component in Mozilla, in
that Live Bookmarks are no longer refreshed every X seconds - as defined by
browser.bookmarks.livemark_refresh_seconds - after hibernate/standby. Perhaps
the Component field of this bug should be set to something more general?

Can someone please dup bug 245471.
Thanks
Did some digging in lxr and filed two bugs:
bug 282013 is slightly related.
This bug should depend on bug 282014.
*** Bug 245471 has been marked as a duplicate of this bug. ***
*** Bug 275727 has been marked as a duplicate of this bug. ***
This behaviour is not only caused by hibernation, but by putting the PC to sleep
too.

Behaviour is still present in version 1.5 Beta 1 (20050908).  It is very
annoying for RSS feeds!
(In reply to comment #12)
> This behaviour is not only caused by hibernation, but by putting the PC to
> sleep too.

I don't see that with any version of TB, 1.0 or 1.5 or 1.6, under Windows 2000.
Bug 179056 is about that situation.  This bug is for hibernate only.
Summary: "Chek for new message every" stops after hibernate → "Check for new message every" stops after hibernate
Um, this is bug 179056. And I can confirm it happens with sleep as well on XP.
(In reply to comment #14)
> Um, this is bug 179056.

Duh, so it is.  It was bug 275727 that was originally opened for both hibernate 
and standby.
Bug 275727 was marked as a dupe of this one, so shouldn't sleep/standby issues be discussed here?
I can confirm that this bug is still present in Thunderbird 1.5 RC1. I have a few additional observations that I haven't seen discussed elsewhere -- perhaps somebody will find something useful in them:

* In my experience, hibernate *usually* produces this problem, but not always. There seems to be a correlation between how long the computer hibernates and whether or not the problem occurs. Generally, if I hibernate for only an hour or two, Thunderbird works fine; however, if I hibernate overnight, Thunderbird won't check mail on schedule anymore.

* After returning from hibernate, if I let Thunderbird sit long enough it will sometimes begin checking messages on schedule again. "Long enough" is occasionally only 20 minutes or so, but is usually several hours. I should note that I don't usually let Thunderbird sit long enough to "fix" itself -- if it doesn't work immediately I usually restart it pretty quickly -- so my experience with this is limited.

* I also use Sunbird 0.2 and I have found that after returning from hibernate, if Thunderbird won't check email, Sunbird's alarm function also won't work. The two go hand-in-hand. Perhaps the bug lies in a common piece of code?
Well, it is a bit deeper. See my Comment #9; This Bug is dependent on Bug 282014. Unfortunately I don not have the right to set it dependent. Bug 282014 ist XPCOM - so _all_ Products have this Problem. You can eaven reproduce it with FF if you use some extension, which needs a timer.
As you noticed right it got better, though.
Depends on: 282014
(In reply to comment #18)
> Bug 282014
> ist XPCOM - so _all_ Products have this Problem. You can eaven reproduce it
> with FF if you use some extension, which needs a timer.

Yes, Live Bookmarks (RSS feeds) stop updating in FF (and TB too I would think, but I don't use TB for RSS) after hibernate.

Assignee: mscott → nobody
QA Contact: huang
At present, wake/sleep notification is only implemented on Mac. They are not notified at all on other platforms.
This patch implements them on Windows.
A Japanese tester said this fixed the problem.
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Attachment #212473 - Flags: review?(emaijala)
Attached patch XPCOM partSplinter Review
Requesting review to Simon who wrote and reviewed a patch for bug 197863.
Attachment #212474 - Flags: review?(sfraser_bugs)
Attachment #212474 - Flags: review?(sfraser_bugs) → review+
Attachment #212473 - Flags: review?(emaijala) → review+
Attachment #212472 - Flags: superreview?(bryner)
Comment on attachment 212472 [details] [diff] [review]
implementing wake/sleep notification

I think we'll want this for 1.8.1 (and possibly but less likely, 1.8.0.2, depending on schedule)
Attachment #212472 - Flags: approval-branch-1.8.1?
Comment on attachment 212472 [details] [diff] [review]
implementing wake/sleep notification

Hm, is the message really dispatched to each window?  That's unfortunate.  I'm a little worried that we could have 0, or more than 1, invisible windows in some cases.  roc would know better than me, can you ask him for review?
Attachment #212472 - Flags: superreview?(bryner) → superreview?(roc)
I didn't know, but I checked the code and it seems pretty clear there's always exactly one hidden window.
Attachment #212472 - Flags: superreview?(roc) → superreview+
checked-in.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
*** Bug 282014 has been marked as a duplicate of this bug. ***
No longer depends on: 282014
Attached patch branch patch (obsolete) — Splinter Review
Bienvenu:
AFAIK, approval‑branch‑1.8.1 flag needs a requestee.
Asking Ere for approval because most of this patch belong to Win32: widget.
Attachment #213042 - Flags: approval-branch-1.8.1?(emaijala)
Comment on attachment 213042 [details] [diff] [review]
branch patch

Sorry, I can't grant approval as I'm not a driver.
Attachment #213042 - Flags: approval-branch-1.8.1?(emaijala) → approval-branch-1.8.1?
for the 1.8.1 branch, you just have to be a module owner
Comment on attachment 213042 [details] [diff] [review]
branch patch

Oh, good to know. Ok then..
Attachment #213042 - Flags: approval-branch-1.8.1? → approval-branch-1.8.1+
Attachment #212472 - Flags: approval-branch-1.8.1? → approval-branch-1.8.1?(roc)
Comment on attachment 212472 [details] [diff] [review]
implementing wake/sleep notification

ere already approved this
Attachment #212472 - Flags: approval-branch-1.8.1?(roc)
Kimura-san:

This patch cannot apply to 1.8 branch.

> patching file widget/src/windows/nsWindow.cpp
> Hunk #1 FAILED at 66.
> Hunk #2 succeeded at 4167 (offset 182 lines).
> Hunk #3 succeeded at 4297 (offset 182 lines).
> 1 out of 3 hunks FAILED -- saving rejects to file widget/src/windows/nsWindow.cpp.rej
> (Stripping trailing CRs from patch.)
> patching file widget/src/windows/nsWindow.h
> Hunk #1 FAILED at 262.
> 1 out of 1 hunk FAILED -- saving rejects to file widget/src/windows/nsWindow.h.rej
> (Stripping trailing CRs from patch.)
> patching file xpcom/threads/TimerThread.cpp
Attached patch branch patchSplinter Review
Oops, that was the same as trunk patch.
Here is a correct one. I've confirmed this is not rejected.
Carrying over branch approval (no actual code change).
Attachment #213042 - Attachment is obsolete: true
Attachment #213172 - Flags: approval-branch-1.8.1+
My MinGW headers don't have these PBT_ constants, do I need to update?
Attached patch fixing mingw bustage (trunk) (obsolete) — Splinter Review
Attachment #213178 - Flags: superreview?(roc)
Attachment #213178 - Flags: review?(roc)
Attachment #213179 - Flags: approval-branch-1.8.1?(roc)
Comment on attachment 213178 [details] [diff] [review]
fixing mingw bustage (trunk)

+#else

unnecessary.
Attachment #213178 - Flags: superreview?(roc)
Attachment #213178 - Flags: superreview+
Attachment #213178 - Flags: review?(roc)
Attachment #213178 - Flags: review+
Comment on attachment 213179 [details] [diff] [review]
fixing mingw bustage (1.8 branch)

but remove the #else.
Attachment #213179 - Flags: approval-branch-1.8.1?(roc) → approval-branch-1.8.1+
Attachment #213178 - Attachment is obsolete: true
Attachment #213313 - Flags: superreview+
Attachment #213313 - Flags: review+
Attachment #213179 - Attachment is obsolete: true
Attachment #213314 - Flags: approval-branch-1.8.1+
checked-in to trunk and 1.8 branch.(fixed mingw bustage)
File :

ftp://ftp.mozilla.org/.1/mozilla/pub/mozilla.org/firefox/nightly/latest-mozilla1.8.0/firefox-1.5.0.2.en-US.win32.zip  
6721 KB  	16/03/2006  	17.26.00

has this patch?

Where can I find first realeses with this patch?
ftp://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/latest-mozilla1.8

however, that's a pre-alpha build. I think it's reasonably stable but hasn't had much testing.
Last firefox 1.5.0.2 still has the problems to take forever to restore from hibernation and reach 100% CPU.

I found interesting the description of bug 325384. It is about SeaMonkey but it
is probably related with the long time to recover from standby.
Plaease consider landing this on 1.8.0 branch.
This will fix some of (but not all) CPU 100% freeze after resore in bug 265172.
And this is baked enough long on trunk and 1.8 branch.
Attachment #219440 - Flags: approval1.8.0.3?
Comment on attachment 219440 [details] [diff] [review]
1.8.0 branch patch

approved for 1.8.0 branch, a=dveditz for drivers.

Please land soon!
Attachment #219440 - Flags: approval1.8.0.3? → approval1.8.0.3+
Sorry, I am not familiar with Mozilla versions.
What does "approved for 1.8.0 branch, a=dveditz for drivers." mean?
Will I see this patch in the next 1.5.0.3 version?
When will it be released?
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.