1791075 - Update PiP Video-Adapter for handling Dailymotion Subtitles

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, enhancement, P2)

Description

[Ania]

Dailymotion must have updated some of the markup, and our existing subtitles adapter is no longer functional.

Let's please look if we can bring it back to life.

+++ This bug was initially created as a clone of Bug #1762309 +++

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

1. Went on dailymotion.com
2. Select a video
3. Enable subtitles on built-in video player
4. Click on PiP button
5. Subtitles do not appear in PiP, only appear in built-in video player

(Some demo videos with subtitles)

• https://www.dailymotion.com/video/x89h6it
• https://www.dailymotion.com/video/x7wtj3p

Actual results:
Subtitles did not appear in the PiP window, they only displayed on the built-in video player.

Expected results:
Subtitles should appear in PiP.

Comment 1

[kpatenio]

While testing my patch for Bug 1770429, I remembered that this bug exists and could not view captions/subtitles on the PiP window. The fix is relatively small, so we might as well address it sooner rather than later.

Comment 2

[kpatenio]

Attachment: Bug 1791075 - update PiP wrapper for dailymotion. r=#pip-reviewers!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46bae4bdde28
update PiP wrapper for dailymotion. r=pip-reviewers,mhowell

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/46bae4bdde28

Comment 5

[Gabi Cheta [:Gabi] Desktop QA]

Verified as fixed with Windows 10x64, Ubuntu 18.4 and macOS 10.12.6 in Firefox 111.0b7 and Nightly 112.0a1.