1816681 - Clean up all sync access handles in WPT fs tests

Status: RESOLVED FIXED

(Core :: DOM: File, defect, P3)

Description

[Jari Jalkanen]

We need t.add_cleanup(() => { syncHandle.close(); }); after every awaited createSyncAccessHandle call, whose result is syncHandle and t is the test handle, otherwise the sync access handles may not be closed if the test is exited due to a failure, and the subsequent tests reusing the same file names will report incorrect errors.

Comment 1

[Jari Jalkanen]

Attachment: Bug 1816681 - Clean up all sync access handles in writable lock WPT test. r=#dom-storage

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c296ef1f0356
Clean up all sync access handles in writable lock WPT test. r=dom-storage-reviewers,jesup

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/c296ef1f0356

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38903 for changes under testing/web-platform/tests

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot