1791527 - Port bug 1790920: Remove nsButtonBoxFrame

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, task)

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Bug 1791527 - Port bug 1790920: Remove nsButtonBoxFrame. r=#thunderbird-reviewers

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1791527 - Port bug 1790920 - Don't check defaultPrevented for click events closing panels. r=freaktechnik

Port of https://hg.mozilla.org/mozilla-central/rev/c152a51ae80c, and some older updates to maybeAutoHidePanel.

Comment 3

[Geoff Lankow (:darktrojan)]

My patch fixes things like the App Menu hiding when things are clicked on, and therefore about half of the test failures. There's still a problem with split toolbar buttons acting as a single button, hopefully Emilio has some ideas.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f082d712ca6f
Port bug 1790920: Remove nsButtonBoxFrame. r=#thunderbird-reviewers,darktrojan
https://hg.mozilla.org/comm-central/rev/16f56004162e
Port bug 1790920 - Don't check defaultPrevented for click events closing panels. r=freaktechnik

Comment 5

[Richard Marti (:Paenglab)]

(In reply to Geoff Lankow (:darktrojan) from comment #3)

My patch fixes things like the App Menu hiding when things are clicked on, and therefore about half of the test failures. There's still a problem with split toolbar buttons acting as a single button, hopefully Emilio has some ideas.

For me the only split button not correctly working is the one in the composer's attachment reminder notification.

Comment 6

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1791527 - Replace both instances of button-menu-button with toolbarbutton-menu-button. r=aleca

The <button> menu-button widget is broken by bug 1790920, but the <toolbarbutton> menu-button widget isn't, so rather than try to fix it and the two uses, this patch abandons the widget and converts the uses to toolbarbutton.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/91c2103b2821
Replace both instances of button-menu-button with toolbarbutton-menu-button. r=aleca

Comment 8

[Richard Marti (:Paenglab)]

Attachment: Bug 1791527 - Style the toolbarbutton.notification-button on the notification bar. r=aleca

Comment 9

[Richard Marti (:Paenglab)]

Is this the last needed patch? Can the leave-open be removed?

Comment 10

[Geoff Lankow (:darktrojan)]

The button in the filters dialog still looks wrong.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/abbb13d8bdfe
Style the toolbarbutton.notification-button on the notification bar. r=aleca

Comment 12

[Richard Marti (:Paenglab)]

(In reply to Geoff Lankow (:darktrojan) from comment #10)

The button in the filters dialog still looks wrong.

I can look at it on Friday.

Comment 13

[Richard Marti (:Paenglab)]

Attachment: Bug 1791527 - Style the toolbarbutton menu-button on the filter dialog. r=aleca

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/909ec22fef3d
Style the toolbarbutton menu-button on the filter dialog. r=aleca