1841477 - message filters dialog: cannot tab to the `new` button

Status: VERIFIED FIXED

(Thunderbird :: Filters, defect, P1)

Description

[David Bailes]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/114.0.0.0 Safari/537.36

Steps to reproduce:

1. Open the message filters dialog.
2. Try to tab to the new button

Actual results:

Cannot make the new button the focus by tabbing to it.

Expected results:

Being able to make the new button the focus by tabbing to it

Comment 1

[Elizabeth Mitchell]

Are you referring to the Quick Filter button?

Are you using a keyboard and monitor only? Or are you also using a screen reader? If you are using a screen reader, which screen reader are you using?

I just tested this on macOS on trunk, Daily, and Beta without a screen reader. The functionality I'm seeing is currently the same. I will test this on Windows to confirm Windows works the same and with a screen reader to confirm the button information is announced properly.

You can select the folder you want and then use Tab to navigate to the message list. Once inside the message list, the first item with keyboard focus using Tab is the Quick Filter button. Pressing Enter on the Quick Filter button allows you to access the Quick Filter options. You can use Tab, left, right, Shift + TAB, and Enter to interact with the buttons.

Currently, if you have more than 1 folder modes activated, Tab will take you to the menus of each folder mode before you get to the message list.

Comment 2

[Richard Marti (:Paenglab)]

No, it's the Message Filters under AppMenu > Tools > Message Filters.

Comment 3

[Wayne Mery (:wsmwk)]

Tools > filters
Tab should get you to the new button, regardless of whether you have any existing filters or not.

Works in version 102.
Works 2022-09-20
Fails 2022-09-21
https://hg.mozilla.org/comm-central/pushloghtml?startdate=2022-09-20+08%3A00%3A00&enddate=2022-09-21+10%3A00%3A00

Comment 4

[Geoff Lankow (:darktrojan)]

Okay, blame me, I converted the buttons to toolbarbuttons, which don't play nicely.

Sol, perhaps you can have a look at this, I know you've been dealing with keyboard issues on drop-down buttons elsewhere. There's this and another one in the "did you mean to add an attachment" notification when composing a message.

Comment 5

[solange]

Attachment: Bug 1841477 - message filters dialog: cannot tab to the 'new' button. r=aleca,elizabeth,darktrojan

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1bbe337536ff
message filters dialog: cannot tab to the 'new' button. r=elizabeth

Comment 7

[solange]

Comment on attachment 9342450 [details]
Bug 1841477 - message filters dialog: cannot tab to the 'new' button. r=aleca,elizabeth,darktrojan

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: "new" button on filter creation would not be keyboard accessible
Testing completed (on c-c, etc.): extensive manual testing, current tests do not break due to it either
Risk to taking this patch (and alternatives if risky): low as it is mostly CSS to show the button being accessible with keyboard navigation

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: "new" button on filter creation would not be keyboard accessible
Testing completed (on c-c, etc.): extensive manual testing, current tests do not break due to it either
Risk to taking this patch (and alternatives if risky): low as it is mostly CSS to show the button being accessible with keyboard navigation

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9342450 [details]
Bug 1841477 - message filters dialog: cannot tab to the 'new' button. r=aleca,elizabeth,darktrojan

[Triage Comment]
Approved for beta

Comment 9

[Daniel Darnell [:dandarnell]]

Thunderbird 116.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/bbf725d98cf5

Comment 10

[David Bailes]

I checked the fix using Thunderbird 116.0b3. I can confirm that I can now Tab to the New split button. However, if I then press Enter or Spacebar, nothing happens. (Using 102.13.0, pressing either of those keys opens a menu containing New and Copy.)
Note that I can open the menu by pressing Alt+Up/Down Arrow, or F4, but not sure if most users would try these. For screen readers, its role is read as being simply "button".
Should this be opened as a separate bug?

Comment 11

[David Bailes]

I've logged a new bug for Spacebar and Enter having no effect, when the new button is the focus.
https://bugzilla.mozilla.org/show_bug.cgi?id=1843511

Comment 12

[Wayne Mery (:wsmwk)]

(In reply to David Bailes from comment #11)

I've logged a new bug for Spacebar and Enter having no effect, when the new button is the focus.
bug 1843511

Thanks! I verify this works on nightly, and beta

Please use format of bug ####### in comments so bugzilla will nicely linkify them

Comment 13

[Wayne Mery (:wsmwk)]

Comment on attachment 9342450 [details]
Bug 1841477 - message filters dialog: cannot tab to the 'new' button. r=aleca,elizabeth,darktrojan

[Triage Comment]
Approved for esr115

Comment 14

[Rob Lemley [:rjl]]

Thunderbird 115.0.1:
https://hg.mozilla.org/releases/comm-esr115/rev/562953466b29