1791777 - Implement CSS parsing support for the @font-palette-values at-rule

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Jonathan Kew [:jfkthame]]

This is somewhat like the existing @font-feature-settings rule (though simpler), and can be implemented along similar lines.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1791777 - patch 1 - Implement CSS parsing for the @font-palette-values rule. r=#firefox-style-system-reviewers

Not yet hooked up to any rendering functionality.

The intention is for both the @font-palette-values at-rule and the font-palette property
to be behind the same pref being introduced here.

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1791777 - patch 2 - Expose @font-palette-values rules in the OM as CSSFontPaletteValuesRule. r=#firefox-style-system-reviewers,#webidl

Depends on D157953

Comment 3

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1791777 - patch 3 - Update WPT expectations now that @font-palette-values is supported. r=#firefox-style-system-reviewers

The couple of remaining test failures relate to an unclear detail of the spec; see
https://github.com/w3c/csswg-drafts/issues/7308
https://github.com/w3c/csswg-drafts/issues/6916

I've implemented the behavior that I think makes most sense, but the current tests disagree.
Once the CSS WG decides which way to clarify this, we can readily fix either the tests or
our implementation.

Depends on D157954

Comment 4

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1791777 - patch 4 - Adjustments to WPT @font-palette-values parsing tests. r=#firefox-style-system-reviewers

In https://github.com/w3c/csswg-drafts/issues/6916, the spec text has been updated to clarify
that the font-family descriptor accepts a list of family names.

Depends on D157955

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d17c257444e
patch 1 - Implement CSS parsing for the @font-palette-values rule. r=emilio
https://hg.mozilla.org/integration/autoland/rev/7de66a218ba4
patch 2 - Expose @font-palette-values rules in the OM as CSSFontPaletteValuesRule. r=emilio
https://hg.mozilla.org/integration/autoland/rev/766386309ee5
patch 3 - Update WPT expectations now that @font-palette-values is supported. r=emilio
https://hg.mozilla.org/integration/autoland/rev/a98dd552df64
patch 4 - Adjustments to WPT @font-palette-values parsing tests. r=emilio

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/36327 for changes under testing/web-platform/tests

Comment 7

[Norisz Fay [:noriszfay]]

Backed out for causing multiple mochitest failures

Backout link

Push with failures

Failure log

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/586c735b005e
patch 1 - Implement CSS parsing for the @font-palette-values rule. r=emilio
https://hg.mozilla.org/integration/autoland/rev/cf87497dbead
patch 2 - Expose @font-palette-values rules in the OM as CSSFontPaletteValuesRule. r=emilio
https://hg.mozilla.org/integration/autoland/rev/5e32d5a01917
patch 3 - Update WPT expectations now that @font-palette-values is supported. r=emilio
https://hg.mozilla.org/integration/autoland/rev/e317795cd27a
patch 4 - Adjustments to WPT @font-palette-values parsing tests. r=emilio

Comment 9

[Cristian Tuns]

Backed out for causing build bustages on TestCOLRv1.cpp

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/gfx/tests/fuzz/TestCOLRv1.cpp:57:55: error: no viable conversion from 'mozilla::gfx::sRGBColor' to 'const mozilla::gfx::Point' (aka 'const PointTyped<mozilla::gfx::UnknownUnits>')

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24ce615e77fd
patch 1 - Implement CSS parsing for the @font-palette-values rule. r=emilio
https://hg.mozilla.org/integration/autoland/rev/a47ae5f76514
patch 2 - Expose @font-palette-values rules in the OM as CSSFontPaletteValuesRule. r=emilio
https://hg.mozilla.org/integration/autoland/rev/af4243189ef1
patch 3 - Update WPT expectations now that @font-palette-values is supported. r=emilio
https://hg.mozilla.org/integration/autoland/rev/6585dd386ee3
patch 4 - Adjustments to WPT @font-palette-values parsing tests. r=emilio

Comment 11

[Noemi Erli[:noemi_erli]]

Backed out 9 changesets (Bug 1791778, Bug 1791782, Bug 1791780, Bug 1791777) for causing build bustages in TestCOLRv1.cpp CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=aN03F1EJTUih2V87hYYHnw.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=linux%2Cx64%2Cdebug%2Cbuild-linux64-fuzzing%2Fdebug%2Cbf&revision=aeb44b79bf31f0e61bfc42939f7d79308cf764a9

Log: https://treeherder.mozilla.org/logviewer?job_id=392630966&repo=autoland&lineNumber=15311

Backout: https://hg.mozilla.org/integration/autoland/rev/f1accadf1754ad5aa8d668ecb22ec8ef1a5bd880

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d7de4f1be55
patch 1 - Implement CSS parsing for the @font-palette-values rule. r=emilio
https://hg.mozilla.org/integration/autoland/rev/e1b9106de285
patch 2 - Expose @font-palette-values rules in the OM as CSSFontPaletteValuesRule. r=emilio
https://hg.mozilla.org/integration/autoland/rev/eb4554c39a2f
patch 3 - Update WPT expectations now that @font-palette-values is supported. r=emilio
https://hg.mozilla.org/integration/autoland/rev/a588e88a1d8b
patch 4 - Adjustments to WPT @font-palette-values parsing tests. r=emilio

Comment 13

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/9d7de4f1be55
https://hg.mozilla.org/mozilla-central/rev/e1b9106de285
https://hg.mozilla.org/mozilla-central/rev/eb4554c39a2f
https://hg.mozilla.org/mozilla-central/rev/a588e88a1d8b

Comment 14

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot