1791780 - Rendering support for custom color-font palettes

Status: RESOLVED FIXED

(Core :: Graphics: Text, enhancement)

Description

[Jonathan Kew [:jfkthame]]

Currently, our COLR-font rendering always uses the font's default palette. The CSS font-palette property and @font-palette-values rule allow authors to choose another palette, or define their own, so the rendering backend needs to allow such palettes to be passed down.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1791780 - Support custom color font palettes in the COLR-font rendering code. r=#gfx-reviewers

This creates the gfx support needed to use alternate palettes, though not yet connected
to the CSS rules/properties to define and access them.

Depends on D157957

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7cc8e027f5a7
Support custom color font palettes in the COLR-font rendering code. r=gfx-reviewers,lsalzman

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.

Comment 4

[Norisz Fay [:noriszfay]]

Backed out for causing multiple mochitest failures

Backout link

Push with failures

Failure log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61bd2a4496bf
Support custom color font palettes in the COLR-font rendering code. r=gfx-reviewers,lsalzman

Comment 6

[Cristian Tuns]

Backed out for causing build bustages on TestCOLRv1.cpp

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/gfx/tests/fuzz/TestCOLRv1.cpp:57:55: error: no viable conversion from 'mozilla::gfx::sRGBColor' to 'const mozilla::gfx::Point' (aka 'const PointTyped<mozilla::gfx::UnknownUnits>')

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9947218170d0
Support custom color font palettes in the COLR-font rendering code. r=gfx-reviewers,lsalzman

Comment 8

[Noemi Erli[:noemi_erli]]

Backed out 9 changesets (Bug 1791778, Bug 1791782, Bug 1791780, Bug 1791777) for causing build bustages in TestCOLRv1.cpp CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=aN03F1EJTUih2V87hYYHnw.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=linux%2Cx64%2Cdebug%2Cbuild-linux64-fuzzing%2Fdebug%2Cbf&revision=aeb44b79bf31f0e61bfc42939f7d79308cf764a9

Log: https://treeherder.mozilla.org/logviewer?job_id=392630966&repo=autoland&lineNumber=15311

Backout: https://hg.mozilla.org/integration/autoland/rev/f1accadf1754ad5aa8d668ecb22ec8ef1a5bd880

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61ed7ee1a32f
Support custom color font palettes in the COLR-font rendering code. r=gfx-reviewers,lsalzman

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/61ed7ee1a32f

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/36528 for changes under testing/web-platform/tests

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot