1791778 - Implement CSS parsing support for the font-palette property

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1791778 - CSS support for the font-palette property. r=#firefox-style-system-reviewers

This is just the CSS parsing, not yet connected to the rendering back-end.

Depends on D157956

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1791778 - Add WPT test for the interaction of font-palette and the font shorthand. r=#firefox-style-system-reviewers

This currently fails in webkit & blink; https://github.com/w3c/csswg-drafts/issues/7832 asks the CSS WG to confirm
whether to keep the existing spec (which is what's implemented here) or change it to match those implementations
(in which case we'll need to do a minor followup to tweak our behavior accordingly).

Depends on D157957

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26d65d76d02a
CSS support for the font-palette property. r=emilio
https://hg.mozilla.org/integration/autoland/rev/8e023280032c
Add WPT test for the interaction of font-palette and the font shorthand. r=emilio

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/36328 for changes under testing/web-platform/tests

Comment 5

[Norisz Fay [:noriszfay]]

Backed out for causing multiple mochitest failures

Backout link

Push with failures

Failure log

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32d171a28810
CSS support for the font-palette property. r=emilio
https://hg.mozilla.org/integration/autoland/rev/4e4eb99a7fd9
Add WPT test for the interaction of font-palette and the font shorthand. r=emilio

Comment 7

[Cristian Tuns]

Backed out for causing build bustages on TestCOLRv1.cpp

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/gfx/tests/fuzz/TestCOLRv1.cpp:57:55: error: no viable conversion from 'mozilla::gfx::sRGBColor' to 'const mozilla::gfx::Point' (aka 'const PointTyped<mozilla::gfx::UnknownUnits>')

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c734ff661a66
CSS support for the font-palette property. r=emilio
https://hg.mozilla.org/integration/autoland/rev/528b4c022a44
Add WPT test for the interaction of font-palette and the font shorthand. r=emilio

Comment 9

[Noemi Erli[:noemi_erli]]

Backed out 9 changesets (Bug 1791778, Bug 1791782, Bug 1791780, Bug 1791777) for causing build bustages in TestCOLRv1.cpp CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=aN03F1EJTUih2V87hYYHnw.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=linux%2Cx64%2Cdebug%2Cbuild-linux64-fuzzing%2Fdebug%2Cbf&revision=aeb44b79bf31f0e61bfc42939f7d79308cf764a9

Log: https://treeherder.mozilla.org/logviewer?job_id=392630966&repo=autoland&lineNumber=15311

Backout: https://hg.mozilla.org/integration/autoland/rev/f1accadf1754ad5aa8d668ecb22ec8ef1a5bd880

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd72ab80c2fd
CSS support for the font-palette property. r=emilio
https://hg.mozilla.org/integration/autoland/rev/2b445c555e74
Add WPT test for the interaction of font-palette and the font shorthand. r=emilio

Comment 11

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/bd72ab80c2fd
https://hg.mozilla.org/mozilla-central/rev/2b445c555e74

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot