regetlastlist returns all bugs

RESOLVED FIXED in Bugzilla 2.18

Status

()

Bugzilla
Query/Bug List
--
blocker
RESOLVED FIXED
15 years ago
5 years ago

People

(Reporter: bbaetz, Assigned: bbaetz)

Tracking

({regression})

2.17
Bugzilla 2.18
x86
Linux
regression

Details

Attachments

(1 attachment)

(Assignee)

Description

15 years ago
regetlastlist changes $::buffer, but then the params object is created from $cgi.

Quick fix - change

my $params = new Bugzilla::CGI($cgi);

to use $::buffer instead

Better fix is to rearrange code a bit; pathc coming
(Assignee)

Comment 1

15 years ago
Created attachment 105670 [details] [diff] [review]
better fix

This is a better fix, in that its ever so slightly more efficent. Rather than
joining the bug_ids again, and then parsing them, create a CGI object with a
prefilled hash.

Also moves $params creation down to when we know it won't be replaced.
Comment on attachment 105670 [details] [diff] [review]
better fix

>-# The params object to use for the actual query itsself
>+# Now we're going to be running, so ensure that the params object is set up

Please use full stops in comments :-) And also, explain why the new CGI object
is created with ||=.

Other than that, r=gerv.

Gerv
Attachment #105670 - Flags: review+
(Assignee)

Comment 3

15 years ago
# Now we're going to be running, so ensure that the params object is set up,
# using ||= so that we only do so if someone hasn't overridden this
# earlier, for example by setting up a named query search.
Keywords: regression
(Assignee)

Updated

15 years ago
Target Milestone: --- → Bugzilla 2.18

Updated

15 years ago
Attachment #105670 - Flags: review+
Comment on attachment 105670 [details] [diff] [review]
better fix

This is just me doing some tests, guys - and I've found a bug, bug 179236.

Gerv
Attachment #105670 - Flags: review+
(Assignee)

Comment 6

15 years ago
Fixed.  
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.