Closed Bug 179188 Opened 23 years ago Closed 23 years ago

New flag system doesn't tell you what the flag was set on in bugmail

Categories

(Bugzilla :: Email Notifications, defect, P1)

Tracking

()

RESOLVED FIXED
Bugzilla 2.18

People

(Reporter: justdave, Assigned: jacob)

References

Details

Attachments

(2 files)

http://bugzilla.mozilla.org/show_bug.cgi?id=179177 bbaetz@student.usyd.edu.au changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |first-review+, second- | |review+ In the old system it said "Attachment #xxxx Status" for the attachment statuses.
Attached patch Take 1Splinter Review
This is admittedly hackish, but it should fix the problem as I observed it. Oddly enough, the patch/obsolete flags did not show this behavior, so...
Ccing the usual suspects. Justdave: was this just for attachment statuses, or is it a bigger problem that I'm missing? Aside: must lay off the coffee...
just for attachment statuses. But you can set flags for bugs now, too, right? Does this take that into account? Bug Flag Attachment #.... Flag etc.
Severity: normal → major
Status: NEW → ASSIGNED
Priority: -- → P1
Well, *that's* a new feature (flags for bugs). I haven't played around with that (nor heard any discussion on it), so I'll venture a guess and say no. I'll play with it and update the patch as necessary.
Comment on attachment 105702 [details] [diff] [review] Take 1 Ideally, this should provide a link to the bug, not just to the status, but that could be a distinct enhancment. r=joel
Attachment #105702 - Flags: review+
This should be: + $what =~ s/^Flag/Attachment #$attachid Flag/ if $attachid; ... as attachment statuses have been renamed flags.
Attachment 105702 [details] [diff] re-introduces the now obsolete term of refering to the flags as attachment status. I've just been looking at this and came up w/a slightly different patch which I'll attach in a minute.
Attached patch Alternate patchSplinter Review
The idea behind this version is that the Show Status page displays an attachment link any time there's an $attachid so the email should too.
One of these days I'll learn to type cvs diff -u :)
Target Milestone: --- → Bugzilla 2.18
Comment on attachment 105705 [details] [diff] [review] Alternate patch this is the right fix r=myk a=myk
Attachment #105705 - Flags: review+
-> me
Assignee: preed → jake
Status: ASSIGNED → NEW
Checking in processmail; /cvsroot/mozilla/webtools/bugzilla/processmail,v <-- processmail new revision: 1.93; previous revision: 1.92 done
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: