1792281 - Hang with 400/502 greeting NNTP code

Status: RESOLVED FIXED

(MailNews Core :: Networking: NNTP, defect)

Description

[Julien ÉLIE]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.0 Safari/605.1.15

Steps to reproduce:

When connecting to a news server that responds
400 Permission denied: Not welcome!
as its initial greeting (instead of 200 or 201 code for instance), the cursor shows a spinning wheel and I do not receive any error message in Thunderbird.

Expected results:

I would have expected an error message in a pop-up.
Thunderbird should handle standard response codes that can be received in the greeting banner (200, 201, 400, 502).
Also note that the 400 response code is similarly not correctly handled (no pop-up with an error message) during the NNTP session, for instance receiving it after authentication or any other command.

Comment 1

[Alfred Peters [:infofrommozilla]]

Confirmed.
Even with a 502 response, the TB does not give any feedback.
The CPP module does.

Comment 2

[Ping Chen [:rnons] (away)]

Attachment: Bug 1792281 - Show error dialog for NNTP server error. r=mkmelin

Pass urlListener and msgWindow to NntpClient before any real action, to receive stop event and show error dialog.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/abcaf011c387
Show error dialog for NNTP server error. r=mkmelin

Comment 4

[Rob Lemley [:rjl]]

Comment on attachment 9296436 [details]
Bug 1792281 - Show error dialog for NNTP server error. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): nntp-js
User impact if declined: NNTP errors not displayed
Testing completed (on c-c, etc.): on beta since 107
Risk to taking this patch (and alternatives if risky):should be low

[Triage Comment]
Approved for 102.5.0

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 102.5.0:
https://hg.mozilla.org/releases/comm-esr102/rev/490e51e9ae90