Closed Bug 1792334 Opened 2 years ago Closed 2 years ago

De-COM nsIXPConnect

Categories

(Core :: XPConnect, task)

task

Tracking

()

RESOLVED FIXED
107 Branch
Tracking Status
firefox107 --- fixed

People

(Reporter: kmag, Assigned: kmag)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

It hasn't been scriptable in years, so there's no need for it to be defined in an IDL, or for any of its methods to be virtual. Among other things, de-COMming it will make it much easier to query in Searchfox.

They haven't been scriptable in years, so there's no need for them to go
through XPIDL or for the methods to be virtual.

Blocks: deCOM

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:kmag, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Flags: needinfo?(kmaglione+bmo)
Flags: needinfo?(continuation)

I spoke to kmag about this earlier this week. He hasn't had a chance to update his patch yet, but it is on his mind.

Flags: needinfo?(kmaglione+bmo)
Flags: needinfo?(continuation)
Pushed by maglione.k@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b5b51c1be2f5
Decom nsIXPConnect and friends. r=mccr8

Backed out for causing build bustages on XPCWrappedJS.cpp

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: /builds/worker/checkouts/gecko/js/xpconnect/src/XPCWrappedJS.cpp(598,24): error: function declared 'stdcall' here was previously declared without calling convention
Flags: needinfo?(kmaglione+bmo)
Flags: needinfo?(kmaglione+bmo)
Pushed by maglione.k@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/124085e3eed1
Decom nsIXPConnect and friends. r=mccr8
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: