1793903 - account central should default to setting up carddav address books

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Magnus Melin [:mkmelin]]

I realized clicking account central "Address Book" will give you a new local address book. I would expect people to prefer connecting to an existing online address book. Having many local address books is not a typical user desire.

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: Bug 1793903 - account central should default to setting up carddav address books. r=aleca

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/903e3dbd6888
account central should default to setting up carddav address books. r=aleca

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 9297387 [details]
Bug 1793903 - account central should default to setting up carddav address books. r=aleca

[Approval Request Comment]
User impact if declined: carddav not as discoverable as it could be
Testing completed (on c-c, etc.): c-c, beta
Risk to taking this patch (and alternatives if risky): super safe

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9297387 [details]
Bug 1793903 - account central should default to setting up carddav address books. r=aleca

[Triage Comment]
Approved for esr102

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9297387 [details]
Bug 1793903 - account central should default to setting up carddav address books. r=aleca

[Triage Comment]
(fixing flag)

Comment 6

[Rob Lemley [:rjl]]

This patch does not apply to comm-esr102, and the code will not work.

Bug 1774763 affects the same lines in msgAccountCentral.xhtml, but doesn't look to be critical for this bug. More importantly, bug 1792612 added the addNewAddressBook() function that this bug ends up using. The latter is marked 'wontfix' for c-esr102, I'm not sure why though.

Comment 7

[Alessandro Castellani [:aleca]]

bug 1792612 was marked wontfix for 102 because we're forcing all dialogs to open as subdialogs of the Address Book, rather than standalone window dialogs, allowing us to remove the shadowDom styling tweaks to be able to use the same dialog in two different ways.
That didn't happen in that bug so we could uplift that as well.

I'm not sure about uplifting this one since it's only a very minor enhancement, not really a defect.

Comment 8

[Rob Lemley [:rjl]]

Attachment: 1793903_esr102.patch

I think the usability improvement intention of this bug warrants uplift, even if it is a minor enhancement. So this is an alternative to uplifting dependencies that make undesirable changes in a stable release.

Essentially the same change as the original patch, but using existing c-esr102 functions.

Try build: https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=478a831ed611d39680311851baf20b696b68dafc

Tested with Fastmail carddav.

Comment 9

[Alessandro Castellani [:aleca]]

Comment on attachment 9301365 [details] [diff] [review]
1793903_esr102.patch

Yeah, looks good

Comment 10

[Rob Lemley [:rjl]]

Comment on attachment 9301365 [details] [diff] [review]
1793903_esr102.patch

[Triage Comment]
Approving esr-specific patch for previously approved bug.

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 102.4.2:
https://hg.mozilla.org/releases/comm-esr102/rev/bece6c033f6b