1794029 - Use timezone definitions from ICU

Status: RESOLVED FIXED

(Calendar :: Internal Components, enhancement)

Description

[Sean Burke [:leftmostcat]]

At present, we maintain our own database of timezone definitions generated by running a script on the IANA timezone database. This requires manual intervention on the release of a new ICU version, at present requires a very specific setup to run, and leaves out a number of valid timezones, causing issues for users.

The ICU library provides facilities for accessing definitions based on the IANA timezone database and is already included and updated in central. Use this as the basis for our timezone definitions instead of maintaining our own.

Comment 1

[Sean Burke [:leftmostcat]]

Attachment: Bug 1794029 - create ICU timezone database service. r=#thunderbird-reviewers

Comment 2

[Magnus Melin [:mkmelin]]

Please rebase, this had bitrotted.

Comment 3

[Sean Burke [:leftmostcat]]

Bitrot addressed.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2b430305eaf4
create ICU timezone database service. r=darktrojan,mkmelin

Comment 5

[Rob Lemley [:rjl]]

This change is causing a ESLint failures in calendar/test/browser/timezones/browser_timezones.js:

TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/test/browser/timezones/browser_timezones.js:91:11 | Octal literals should not be used. (no-octal)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/test/browser/timezones/browser_timezones.js:101:11 | Octal literals should not be used. (no-octal)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/test/browser/timezones/browser_timezones.js:111:11 | Octal literals should not be used. (no-octal)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/test/browser/timezones/browser_timezones.js:121:11 | Octal literals should not be used. (no-octal)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/test/browser/timezones/browser_timezones.js:131:11 | Octal literals should not be used. (no-octal)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/test/browser/timezones/browser_timezones.js:141:11 | Octal literals should not be used. (no-octal)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/test/browser/timezones/browser_timezones.js:151:11 | Octal literals should not be used. (no-octal)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/test/browser/timezones/browser_timezones.js:161:11 | Octal literals should not be used. (no-octal)

Due to bug 1797759, Treeherder marked ESLint tests as successful/green even though there were errors present. Fix for these errors should be easy enough, don't use "00", just "0" as seen in lines 57-66 of the same file.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bf22a7963e7e
follow-up, fix linting errors exposed with the fix of bug 1797759. rs=eslint

Comment 7

[Magnus Melin [:mkmelin]]

Took care of the linting.