1794579 - Hide private browsing section for SitePermsAddons in about:addon

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P2)

Description

[William Durand [:willdurand]]

From https://phabricator.services.mozilla.com/D158931:

• properly handle the private browsing checkbox shown in the post-install doorhanger
• properly handle the about:addons "allow in private browsing tabs" control

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1794579 - Handle permissions for different origin attributes in SitePermsAddonProvider. r=rpl

In SitePermsAddonWrapper, we are keeping track of permission with a uniqueness on the permission type.
But for a given permission type and origin, multiple permissions can be set (for PB, contexts, ...).
This patch make it so we bookkeep all the permission that are passed, so we can then later properly
remove them when the addon gets uninstalled, or when individual permission are being revoked.

Comment 2

[Phabricator Automation]

Comment on attachment 9298677 [details]
Bug 1794579 - Handle permissions for different origin attributes in SitePermsAddonProvider. r=rpl

Revision D159420 was moved to bug 1795359. Setting attachment 9298677 [details] to obsolete.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1794579 - Hide private browsing section for SitePermsAddons in about:addon. r=rpl.

This patch adds PERM_CAN_CHANGE_PRIVATEBROWSING_ACCESS to SitePermsAddonWrapper#permissions
getter so we show the "Run in private windows" UI in the post-install notification
and in about:addons.
In order to handle changes made to the input, we add a reload method that will
take care of adding/updating/removing permissions depending on the value selected
by the user.

Basically, if the user enable "Run in private windows", we want to add permanent
permissions for private principals, and if the user disable it, we want to remove
any granted permissions on private principals.
On top of that, when the user revoke a permission from a private window, we disable
"Run in private windows" so it's consistent with the user last choice.

Depends on D159569

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

as discussed on phabricator with Luca, taking care of the private browsing state for SitePermsAddons might require more work than we thought, so I'm slightly changing the overall goal of this bug so we can enable the provider during this cycle.
I filed Bug 1799090 to address the original issues that were raised on this bug

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1dd01e4b2ead
Hide private browsing section for SitePermsAddons in about:addon. r=rpl.

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/1dd01e4b2ead