1795359 - SitePermsAddonProvider and SitePermsAddonWrapper entries should account for the gated permission to be granted for multiple principal sharing the same siteOriginSuffix

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

STR:
(1) fresh profile, flip the pref, restart.
(2) Go to https://ryoyakawai.github.io/smfplayer/ , accept the addon install prompt. Verify it shows up in about:addons.
(3) Open a PB window. Go to https://ryoyakawai.github.io/smfplayer/ . See new prompt. Accept prompt.
(4) Close PB window. Reopen PB window, see that access is still allowed.
(5) Go to about:addons and remove the addon.
(6) Restart browser, addon reappears in about:addons

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1795359 - Handle permissions for different origin attributes in SitePermsAddonProvider. r=rpl

In SitePermsAddonWrapper, we are keeping track of permission with a uniqueness on the permission type.
But for a given permission type and origin, multiple permissions can be set (for PB, contexts, ...).
This patch make it so we bookkeep all the permission that are passed, so we can then later properly
remove them when the addon gets uninstalled, or when individual permission are being revoked.

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1795359 - Account for gated permission granted to multiple principals sharing the same siteOriginSuffix. r?willdurand,nchevobbe!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac1330b68d3e
Handle permissions for different origin attributes in SitePermsAddonProvider. r=rpl

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/ac1330b68d3e

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1795359 - Handle permissions.isolateBy.userContext in test_sitePermsAddonProvider. r=rpl.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d236f29e2be4
Handle permissions.isolateBy.userContext in test_sitePermsAddonProvider. r=rpl.

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d236f29e2be4

Comment 9

[Alex Cornestean]

Hello,

Verified as Fixed on the latest Nightly (109.0a1/20221116182402) and Beta (108.0b2/20221115200658). Tested on Windows 10 x64 and Ubuntu 16.04 LTS.
Following the STR from Comment 0, upon performing Step 6, the add-on does not reappear in about:addons, confirming the fix.

For further details, see the attached video depicting the STR being performed on Nightly. Same results are obtained on Beta so I did not attach a video from that version.

Comment 10

[Alex Cornestean]

Attachment: 2022-11-17_09h49_04.mp4