1795751 - Contribute button for addons does not work in 102

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: General, defect)

Description

[david]

Steps to reproduce:

Click any addon in Thunderbird that has a 'contribute' button. Click it and nothing happens.

Actual results:

Nothing. It should have opened a web page to allow user to contribute funds to developer.

Expected results:

A web page should have opened that accepted financial contribution.

Comment 1

[John Bieling (:TbSync)]

Attachment: contribute.png

I cannot confirm this. Maybe the link at the specific add-on you tested is broken (wrongly configured by the developer)?

The contribute button for TbSync works:
https://addons.thunderbird.net/en-US/thunderbird/addon/tbsync

What add-on have you experienced this with?

Comment 2

[John Bieling (:TbSync)]

I of course tested this in Thunderbird, after having searched for TbSync inside the Add-on Manager.

Comment 3

[david]

I tested with These plugins and the Contribute button did nothing:

• EditEmailSubject MX
• ImportExportTools
• Provider for Google Calendar
• ThunderHTMLedit
• ToggleHTML
• Xpunge

Comment 4

[John Bieling (:TbSync)]

Each of those works for me.

Note: The contribute page should be opened in your default browser, not in Thunderbird.
Do you have a default browser configured?
What is your OS?

What happens if you click on the "Add-on home page" button of one of those add-ons?
What happens if you click on the sign-in button in the top right?

Comment 5

[david]

I use windows 11, latest Thunderbird, and Firefox is default. When I click a URL in email, the page opens right up. A user on SUMO reported the issue, and when I found it was the same for me, I created this bug report. When I click an addon's home page, the browser opens properly to the page. Sign-in worked properly. Puzzling.

Comment 6

[John Bieling (:TbSync)]

Do you see any error on the console (Tools -> Developer Tools -> Error Console), which are triggered when clicking on the contribute button?

Comment 7

[david]

I've never used developer tools, but I did see this:
Uncaught (in promise) TypeError: windowRoot.ownerGlobal.openUILinkIn is not a function
handleEvent chrome://mozapps/content/extensions/aboutaddons.js:3126

Comment 8

[John Bieling (:TbSync)]

Thanks. At least an error message to work with!

But I have no idea where this is called, we do not use it at all (only suite, which is old Seamonkey code):
https://searchfox.org/comm-esr102/search?q=openUILinkIn&path=&case=true&regexp=false

You are using a genuine Thunderbird 102, downloaded from thunderbird.net, right?

Comment 9

[Richard Marti (:Paenglab)]

I tried 102, Daily and self built TB. All fail with the same error when I try the Contribute button of ThunderHTMLEdit.

Comment 10

[John Bieling (:TbSync)]

Attachment: contribute2.png

Got it. You did not click the contribute button on an ATN page viewed inside Thunderbird (which my first screenshot pointed to), but in the details page of an add-on. Correct?

At least I can reproduce the error there now. :-)

Comment 11

[david]

Yes, pure Thunderbird. In fact, I just reinstalled and continue to receive the error:
Uncaught (in promise) TypeError: windowRoot.ownerGlobal.openUILinkIn is not a function
handleEvent chrome://mozapps/content/extensions/aboutaddons.js:3126

Comment 12

[John Bieling (:TbSync)]

Attachment: Bug 1795751 - Implement missing openUILinkIn(). r=mkmelin

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d19295ace812
Implement missing openUILinkIn(). r=mkmelin

Comment 14

[b4]

Last broken in bug 1500895.

Comment 15

[Rob Lemley [:rjl]]

Comment on attachment 9299239 [details]
Bug 1795751 - Implement missing openUILinkIn(). r=mkmelin

[Triage Comment]
Approved for beta, let's get this on 102 as it could affect addon contributions

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: Potentially affects addon authors revenue.
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):Low, implements a missing function

TBSync - Any objections to this uplift request?

Comment 16

[Daniel Darnell [:dandarnell]]

Thunderbird 107.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/1648e90d5ce8

Comment 17

[Wayne Mery (:wsmwk)]

Comment on attachment 9299239 [details]
Bug 1795751 - Implement missing openUILinkIn(). r=mkmelin

[Triage Comment]
Approved for esr102

Comment 18

[Rob Lemley [:rjl]]

Thunderbird 102.5.0:
https://hg.mozilla.org/releases/comm-esr102/rev/1b07d3181e76