1500895 - Contribute button on add-on details page doesn't work

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: General, defect)

Description

[Onno Ekker [:nONoNonO UTC+1]]

Attachment: Contributions URL on ATN

Add-on developers have an option to specify a contributions URL for users to make a donation. This URL is added to the details page of the add-on.
When you click this Contribute button in Thunderbird, nothing happens.

Expected results:
The URL specified on addons.thunderbird.net should open in a tab.

Actual results:
The following error appears in the errorconsole:
NS_ERROR_XPC_CANT_MODIFY_PROP_ON_WN: Cannot modify properties of a WrappedNative  contentAreaUtils.js:1230
	openURL chrome://global/content/contentAreaUtils.js:1230:7
	doCommand chrome://mozapps/content/extensions/extensions.js:1398:9
	doCommand chrome://mozapps/content/extensions/extensions.js:1524:5
	initialize/< chrome://mozapps/content/extensions/extensions.js:132:5

Note: if you flip network.protocol-handler.expose.http and/or network.protocol-handler.expose.https to false, the contritions URL is opened correctly in your browser.

Comment 1

[Onno Ekker [:nONoNonO UTC+1]]

Attachment: Add-on with Contribute button.png

Comment 2

[Jorg K (CEST = GMT+2)]

Maybe Andrei might want to look into this one.

Comment 3

[Onno Ekker [:nONoNonO UTC+1]]

I did some testing with mozregression-qui and found this regression range:
comm-central 58.0a1
Last known good: 20170924030211 (platform_changeset: ff40c5dcaa41261b39a4e9795e02a9d51dd30ced)
First known bad: 20170925030209 (platform_changeset: 5f3f19824efa14cc6db546baf59c54a0fc15ddc9)

So it's been broken for quite some time now, which might explain that I hardly ever get any donations anymore :~(

Strange thing is that when it worked, it always opened the URL in the browser, regardless of the setting of network.protocol-handler.expose.https.

Comment 5

[Andrei Hajdukewycz [:sancus]]

This might be an easier fix for people who are working on TB regularly, but I haven't touched the client in a couple of months and am currently buried in website/atn/telemetry work, so I don't have any plans to look at this right now.

Comment 6

[Merike Sell (:merike)]

This is related to changes in bug 1360603 and https://hg.mozilla.org/mozilla-central/rev/6d7610f4d26d

Comment 7

[Philippe VIGNEAU]

the contribute button now works with Thunderbird Daily (but still not with Thunderbird 68.0b4)

Comment 9

[Jorg K (CEST = GMT+2)]

Clicking on the "Contribute" button gives this in the console:

NS_ERROR_XPC_CANT_MODIFY_PROP_ON_WN: Cannot modify properties of a WrappedNative contentAreaUtils.js:1226
openURL chrome://global/content/contentAreaUtils.js:1226
doCommand chrome://mozapps/content/extensions/extensions.js:1374
doCommand chrome://mozapps/content/extensions/extensions.js:1489
initialize chrome://mozapps/content/extensions/extensions.js:123

The offending code is this:

    if (channel) {
      channel.channelIsForDownload = true;
    }

Yes, that was added in bug 1360603, https://hg.mozilla.org/mozilla-central/rev/6d7610f4d26d#l1.12, I'll just see what happens if we remove those three lines. Not so easy to do, since it works in Daily, so I'd have to do it on the TB 68 try build.

It was most likely fixed when the entire add-ons manager was replaced in FF in bug 1555012 and TB followed in bug 1565180.

Comment 10

[Jorg K (CEST = GMT+2)]

Aryx, can you explain to me how you modified a file in omni.ja in bug 1567783 comment #5. I'd like to do this here. I know that you can unpack it and then remove it and TB runs on the unpacked files, but I was never able to modify the content.

Comment 11

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ff40c5dcaa41261b39a4e9795e02a9d51dd30ced&tochange=5f3f19824efa14cc6db546baf59c54a0fc15ddc9, yep, bug 1360603 is in that range.

Comment 12

[Jorg K (CEST = GMT+2)]

Well, if removing those three lines helps, I'll do it for TB 68.

Comment 13

[Jorg K (CEST = GMT+2)]

OK, I followed https://www.raymond.cc/blog/edit-files-inside-firefox-4-omni-jar-to-auto-save-password/
Basically downloaded optimizejars.py, copied TB's omni.ja to omni.jar in a temp directory, python optimizejars.py --deoptimize ./ ./ ./t where t was another temp directory. The resulting omni.jar could be edited in 7zip and the modification written back to the archive. Optimise again python optimizejars.py --optimize ./ ./t ./tt and copy the result back to the TB program directory as omni.ja. And the result: Ta-dah, TB crashed when launched :-(

Comment 14

[Jorg K (CEST = GMT+2)]

Hmm, this comment got lost somehow:

Aryx, can you explain to me how you modified a file in omni.ja like you said in bug 1567783 comment #5. I know that you can unpack it and then remove it and TB runs on the unpacked files, but I was never able to modify the content (last failed attempt in comment #13 above).

Comment 15

[Jorg K (CEST = GMT+2)]

OK, I did the unpack trick and modified: chrome\toolkit\content\global\contentAreaUtils.js:1226
After that the links work. I'll fix it via a backout of that patch in the final release.

Comment 16

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

How I do it:

1. Copy the install directory.
2. Unzip the omni.ja with 7-Zip (recent versions support the omni.ja), ignore the warning.
3. Find the file you want to modify.
4. Edit it and save it.
5. Select all files.
6. Create a zip file (format zip, compression deflate) and name it omni.ja
7. Replace the omni.ja in the application directory with the one you created.
8. Launch the application, e.g. with thunderbird.exe -no-remote -P "Coding-central" -purgecaches

Comment 17

[Jorg K (CEST = GMT+2)]

TB 68.0 ESR, fixed via backout:

https://hg.mozilla.org/releases/mozilla-esr68/rev/2f459603370d1d35a56ca4e9cee21f7766bbb832 on THUNDERBIRD_68_VERBRANCH
Backed out changeset 6d7610f4d26d (bug 1360603 for causing bug 1500895) to build Thunderbird 68.0. a=jorgk DONTBUILD

Thanks for your answer, Aryx.

Comment 18

[Jorg K (CEST = GMT+2)]

This is working now. Windows build here:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=4a0e4fac7b7fe74c070d6f9d00294e02bc4e5382
You can install it by clicking onto the "B" and under "Job Details" getting target.zip or target.installer.exe.

Comment 19

[Jorg K (CEST = GMT+2)]

Broken for a long time.

Comment 20

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/releases/mozilla-esr68/rev/94d72e1f80e04d5eb95a214b073ea945ebcfe454 on THUNDERBIRD_68_VERBRANCH for >= 68.1