1795811 - Progress bar is not announced by NVDA on the Onboarding screens

Status: RESOLVED DUPLICATE of bug 1790387

(Firefox :: Messaging System, defect, P3)

Description

[Anna Yeddi [:ayeddi]]

STR:

1. Activate NVDA screen reader
2. Open the Firefox browser
3. Open the Browser Console and enter:
   Cc["@mozilla.org/browser/browserglue;1"].getService().wrappedJSObject._showUpgradeDialog()
4. Listen to the page announcement (or press Ins + Down Arrow to read-all)
5. On the opened onboarding page, navigate to the progress bar component using Down arrow keypresses.
6. With NVDA running, hover over the progress bar with a mouse. Repeat for all onboarding pages

Expected:

1. The current position of the stepper is included in the full page announcement.
2. The progress bar can be accessed by an NVDA in a reading mode (Down arrow), it announces a role of the stepper and its current position (i.e. on macOS it is progress, step 1 of 4, level indicator)
3. When hovered over, the progress bar is announced by NVDA.

Actual:

1. The stepper is not mentioned in the full page announcement.
2. The progress bar cannot be accessed by an NVDA in a reading mode (Down arrow), it is hidden from a screen reader user.
3. When hovered over, nothing is announced by NVDA

Version: Firefox Nightly 107.0a1 (2022-10-17) on Windows OS 11.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:tspurway, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, [access-s2].
:emcminn, could you consider increasing the severity?

For more information, please visit auto_nag documentation.

Comment 3

[Emily McMinn :emcminn]

This should be fixed by changing the step indicator role from meter to progressbar; which will be done in the patch for Bug 1790387.

Comment 4

[Emily McMinn :emcminn]

Hi @ayeddi; would you mind verifying this bug again? It should have been fixed by the linked patch; I've been able to get the progress bar being read on hover, but I'm having trouble getting NVDA to do a full page read of the upgrade dialog (probably user error) so I haven't been able to verify the other issues/

Comment 5

[Anna Yeddi [:ayeddi]]

(In reply to Emily McMinn :emcminn from comment #4)

Hi @ayeddi; would you mind verifying this bug again? It should have been fixed by the linked patch; I've been able to get the progress bar being read on hover, but I'm having trouble getting NVDA to do a full page read of the upgrade dialog (probably user error) so I haven't been able to verify the other issues/

Hi @Emily, thank you for testing it out! I have exactly the same results as you do:

1. The progressbar is announcing its role, label, and state
2. The label includes the state too, so it is a bit redundant: Progress: step 1 of 4, 1 but it seems minor (maybe a bit confusing, but minor)
3. Only tab key works for navigation - arrow keys are not doing anything on these particular pages. This is not expected... And Up/Down arrows work with NVDA on other page as expected, so this is the Onboarding experience's bug and not a user error as you mentioned. I am not sure if it is related, but I was not able to do the right click press on the page too (I am not concerned about it though)
4. The subtitle (that is made as <h2>) is not announced when the page is being announced on load. You can only hear it when hovering over. Note: the entire page is only being announced when the page is opened initially, as mentioned above, arrow keys do nothing thus read-all mode is not working. Another item not being announced is the image (only on hover)

Comment 6

[Punam Dahiya [:pdahiya]]

From comment #5 , looks like the issue around progress bar read by screen reader is resolved and fixed with Bug 1790387 NI @emcminn to confirm and mark bug resolved duplicate of 1790387 . If the bug is reused for any remaining accessibility fixes, will be good to update bug title to reflect that. Thanks

Comment 7

[Emily McMinn :emcminn]

(In reply to Punam Dahiya [:pdahiya] from comment #6)

From comment #5 , looks like the issue around progress bar read by screen reader is resolved and fixed with Bug 1790387 NI @emcminn to confirm and mark bug resolved duplicate of 1790387 . If the bug is reused for any remaining accessibility fixes, will be good to update bug title to reflect that. Thanks

I've gone back and forth on this a bit and I think for clarity it'll be best to close this bug as a duplicate, and open another one to focus on the navigation & full page read issues since I think those affect Feature Callout as well as onboarding. I'll file something today!