1796029 - Searching from address bar stopped working, returns "We’re having trouble finding that site" error page

Status: VERIFIED FIXED

(Firefox :: Search, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: screenshot.png

I updated my Firefox Nightly on Windows today and now address bar searches stopped working. If I search for "test", Firefox tries to load test.com and shows a "We’re having trouble finding that site" error page.

@standard8, could your changes in policy engine bug 1445134 have caused a search regression like that?

I don't see this problem in a clean profile, so I bisected the problem using my main profile and landed on an autoland regression range that includes this bug. I don't know yet what is different about my main profile.

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=1c029b0ffc31502257687bce117d21804d34c8ef&tochange=7595f36ef24cd3deb657f0881148f477dc8a6509

Comment 1

[Chris Peterson [:cpeterson]]

Even URLs from my local history are no longer shown when I type in the address bar.

Restarting in safe mode doesn't help.

Comment 2

[Dianna Smith [:diannaS]]

Comment 3

[Chris Peterson [:cpeterson]]

FWIW, I just refreshed my Nightly profile and now I can no longer reproduce. I tried to back up my profile before refreshing, but I accidentally backed up the wrong folder so I can't revert to my broken, pre-refreshed profile.

Comment 4

[Molly Howell (she/her) (mostly inactive)]

I have a profile that can reproduce this also. Here's what I'm seeing in my console:

20:10:23.735 SearchService: #init: failure initializing search: TypeError: can't access property "includes", engineSettings._loadPath is undefined
    #shouldDisplayRemovalOfEngineNotificationBox resource://gre/modules/SearchService.sys.mjs:1625
    #loadEngines resource://gre/modules/SearchService.sys.mjs:1559
SearchService.sys.mjs:1331:23
    #init resource://gre/modules/SearchService.sys.mjs:1331

That line was added in bug 1445134 (specifically in D159033), so it does indeed seem to be the patch of interest.

Comment 5

[Fanael Linithien]

I can reproduce it in a fresh profile by changing the default search engine in preferences and restarting.

Comment 8

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Hello,

Managed to reproduce this issue with 108.0a1(20221018213916) using Windows 10ARM, Windows 11, macOS 10.15 and Ubuntu 22.

As per mentioned in comment 5, the STR are:

• Launch FF.
• Go to about:preferences#search
• Change the default search engine (e.g to Bing)
• Restart FF

After the restart , it can be noticed that no search engine in selected .

Attempting to pull a regression range returns the following results :

2022-10-19T09:07:15.681000: INFO : Narrowed integration regression window from [1c029b0f, 1c827475] (3 builds) to [1c029b0f, 7595f36e] (2 builds) (~1 steps left)
2022-10-19T09:07:15.688000: DEBUG : Starting merge handling...
2022-10-19T09:07:15.688000: DEBUG : Using url: https://hg.mozilla.org/integration/autoland/json-pushes?changeset=7595f36ef24cd3deb657f0881148f477dc8a6509&full=1
2022-10-19T09:07:17.002000: DEBUG : Found commit message:
Bug 1445134 - Load policy engines from enterprise policies at search service startup. r=mkaply,mcheang

Rather than having the enterprise policy push engine information to the search service, this pulls it from the policies whilst initialisation is in progress. This will ensure the search service always has the correct information for policy engines even if the search settings file is modified.

Differential Revision: https://phabricator.services.mozilla.com/D156538

2022-10-19T09:07:17.002000: DEBUG : Did not find a branch, checking all integration branches
2022-10-19T09:07:17.003000: INFO : The bisection is done.

So it does seem that 1445134 would be the culprit for this issue, as cpeterson stated in the above comments.

Comment 10

[Francesco Lodolo [:flod]]

@standard8
Do you know if this could also cause issues with the home page (bug 1796056)?

Comment 11

[Mark Banner (:standard8)]

Attachment: Bug 1796029 - Fix search code when checking to display a notification to handle cases where information is not present. r?daleharvey

Comment 12

[Mark Banner (:standard8)]

(In reply to Francesco Lodolo [:flod] from comment #10)

@standard8
Do you know if this could also cause issues with the home page (bug 1796056)?

Yes, it would cause issues with the search bar on the home page, and the separate search bar.

Comment 13

[Mark Banner (:standard8)]

Sorry for the problems here, I'm not quite sure how we missed this case. The patch extends the tests to cover it.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba1c7b459372
Fix search code when checking to display a notification to handle cases where information is not present. r=daleharvey

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/b7be85a10f69
Fix search code when checking to display a notification to handle cases where information is not present. r=daleharvey

Comment 16

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/b7be85a10f69

Comment 17

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/ba1c7b459372

Comment 19

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Hello,

Confirming this issue as verified fixed on 108.0a1(20221112215806) using Windows 11, Windows 10ARM, macOS 12 and Ubuntu 22.