1796698 - Firefox Translations notification banner elements do not line up

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Fanolian]

Attachment: Firefox Translatoin notification banner.png

Steps to reproduce

1. In a new profile, install Firefox Translations.
2. Go to a page that can be translated. E.g. https://es.wikipedia.org/wiki/Wikipedia:Portada.
3. See the notification banner.

Actual result

Elements do not line up.

p.s. Bug 1790616 fixed bug 1794819.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1796698 - Don't set explicit height on the notification image icon. r=Gijs,dao

Modern flexbox will honor it rather than stretching and effectively
centering the icon.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

There are various layout issues in this modal. The icon I can fix in mozilla-central at least. Is the extension going to move to mozilla-central in the short term? It seems to have a lot of issues and it's hard to fix. Alternatively, can it not use XUL?

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1790616

Comment 4

[André Natal]

Alternatively, can it not use XUL?

If a privileged extension can open a popup programmatically [1][2], yes, with proper UI/UX support and given a Firefox front-end engineer develops it.

[1] https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Popups
[2] However, you can't open the popup programmatically from an extension's JavaScript; it can be opened only in response to a user action.

I don't have an answer to your other questions though so will defer to who might.

Comment 5

[Sylvestre Ledru [:Sylvestre]]

This is TBD. We will know more next week.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bac2a46dd313
Don't set explicit height on the notification image icon. r=dao

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/bac2a46dd313

Comment 8

[Emil Ghitta, QA [:emilghitta]]

I've reproduced this issue using Firefox 108.0a1 (BuildId:20221020215126) on Windows 10 64bit

This issue is verified fixed (for the icon) using Firefox 108.0b3 (BuildId:20221117185908) on Windows 10 64bit, macOS 11 & Ubuntu 22.04.