1794819 - Dropdown menu from button Options in notification banner does not show correctly

Status: RESOLVED WORKSFORME

(Firefox :: Translations, defect)

Description

[Fanolian]

Attachment: Translation notification banner Options.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:107.0) Gecko/20100101 Firefox/107.0
Build ID: 20221011160345

Steps to reproduce

1. In a new profile, install Firefox Translations.
2. Go to a page that can be translated to trigger the notification banner. E.g. https://es.wikipedia.org/wiki/Wikipedia:Portada.
3. Click Options on the banner.
4. Observe the dropdown menu.

Actual result

Last item is overlapped by a down chevron scroll button. Hovering on the button does not scroll down enough to show all the text.

Expected result

There is no need for the scroll button.

Regression

Last good Nightly: 2022-09-01
First bad Nightly: 2022-09-02
pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=136f13b75057ef4c2419dba0d63e913d502c7458&tochange=050487abb54ae6d2c7d6a78b5de60ac6efbab9ba

Bisecting autoland builds:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=33a3e6eafcdb8acb7ccf6f8d2372a1a566a6b2dc&tochange=3477776b80ac0035ec6b285b21931b06261bae15

This should be regressed by bug 1734220.

Notes

I don't know if bug 1788595 or https://github.com/mozilla/firefox-translations/issues/496 would fix this bug.

There is another unrelated bug regarding button Translate this tab automatically as you browse which I filed bug 1794817.

Comment 1

[Fanolian]

Attachment: Firefox Translatoin button.png

Uploaded a wrong image.

Comment 2

[Fanolian]

Attachment: Firefox Translation Options.png

Edited the wrong bug... Sorry for the spam.

Comment 3

[Francesco Lodolo [:flod]]

Bug 1788595 would definitely not fix this (it would remove files that are unused in mozilla-central), the refactor needed for it in the add-on might.

It seems strange that the Fluent migration bug would cause display issues in the menu though (which is also displayed in its entirety on macOS Nightly).

Comment 4

[Eemeli Aro [:eemeli]]

Are you quite sure that this was a regresssion from bug 1734220, and not bug 1790920? I'm struggling to figure out how the changes in patch D155110 could have caused this.

Is the m-c code in components/translation/content/translation-notification.js perhaps somehow depended on by the extension?

Comment 5

[Fanolian]

Attachment: Options 2022-09-02.png

This screenshot is taken on 2022-09-02 build. `Translate this tab automatically…" is not bugged so the Options button bug is not regressed by bug 1790920 which landed after bug 1734220.

I used Mozregression on a different computer with a different OS scaling and text size setup. I got the same regression range so it should not be a OS problem.
I don't know how to apply patch locally to pinpoint the regression as the regression range contains bug 1734220 and bug 1785216.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1734220

Comment 7

[Eemeli Aro [:eemeli]]

As with Flod, I'm not able to reproduce this on my Macbook, so debugging this is quite challenging. As a wild guess, is there perhaps some added delay in loading a DTD file now that it's only used by this extension that's affecting the timing of when the menu's initial size is measured?

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1734220

Comment 9

[Fanolian]

This bug is fixed in 2022-10-18 build, probably by bug 1790616.
Fix range: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a41265da4a2a475ed7cde77c9aa285ecdf413f3b&tochange=d728a45552226ef4a36bab51796d60931e13582c

Comment 10

[Fanolian]

Attachment: Never translate [lang].png

Never translate [language] is still cropped out.

Comment 11

[Francesco Lodolo [:flod]]

This might be caused by the menu having an empty item (because it searches for translation.properties to build the string)

If that's the case, this would fix it. But there's no way to tell, since this menu shows up correctly on macOS also in the existing version of the add-on
https://github.com/mozilla/firefox-translations/pull/527

Comment 13

[Francesco Lodolo [:flod]]

AFAIK, 106 is not affected, this is 107+ (the original report is for 107).

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:florian, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 16

[Fanolian]

Issue at comment 10 is also fixed in Firefox Translations 1.2.0 released today.