1796849 - Theming in private windows is messed up in KDE Plasma

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[logicalwillow]

Attachment: Right-click menu in private browsing window

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:106.0) Gecko/20100101 Firefox/106.0

Steps to reproduce:

1. Use the Breeze Light theme in Plasma
2. Open a private browsing window in Firefox
3. Right click somewhere or hover over something

Actual results:

Firefox uses Adwaita, not Breeze, for menus and other things. Tooltip text is white on a light background, making it unreadable.

Expected results:

Firefox uses the Breeze Dark theme for menus and tooltips in private browsing windows.

Comment 1

[logicalwillow]

Attachment: Tooltip

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

The fact that we use adwaita dark instead of breeze dark is a KDE bug (see https://bugs.kde.org/show_bug.cgi?id=448877, in particular the third bullet point in there). The white-on-white tooltip is an issue we should fix tho (we're using the adwaita text color but the breeze light theme, because there can only be one GTK theme loaded at the time).

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1796849 - Teach the non-native theme to draw tooltips. r=stransky

We haven't seen this with Adwaita because it uses dark tooltips in both
light and dark mode, so stuff kinda worked out in the end.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1751481

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/071dbd17c226
Teach the non-native theme to draw tooltips. r=stransky

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/071dbd17c226

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox107 to wontfix.

For more information, please visit auto_nag documentation.

Comment 9

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 9299735 [details]
Bug 1796849 - Teach the non-native theme to draw tooltips. r=stransky

Beta/Release Uplift Approval Request

• User impact if declined: Tooltips are broken in private windows in some GTK themes.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Relatively straight-forward change.
• String changes made/needed: none
• Is Android affected?: No

Comment 10

[Donal Meehan [:dmeehan]]

Comment on attachment 9299735 [details]
Bug 1796849 - Teach the non-native theme to draw tooltips. r=stransky

Approved for 107.0b5.

Comment 11

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/cc88621db6fb

Comment 12

[Monica Chiorean]

I could not reproduce the issue before the fix in order to confirm the fix, using Firefox build 106.0 on Ubuntu 20.04 and VM Fedora 36 / Fedora KDE. I tried all themes: Breeze Light, KDE Plasma Dark, KDE Breeze Dark Compatible, Plasma Breeze.
Reporter, can you please confirm issue is not preproducing on Nightly build(https://archive.mozilla.org/pub/firefox/nightly/2022/10/2022-10-26-22-42-58-mozilla-central/) and Beta build(https://archive.mozilla.org/pub/firefox/candidates/107.0b5-candidates/).
Thank you so much.

Comment 13

[logicalwillow]

(In reply to Monica Chiorean from comment #12)

I could not reproduce the issue before the fix in order to confirm the fix, using Firefox build 106.0 on Ubuntu 20.04 and VM Fedora 36 / Fedora KDE. I tried all themes: Breeze Light, KDE Plasma Dark, KDE Breeze Dark Compatible, Plasma Breeze.
Reporter, can you please confirm issue is not preproducing on Nightly build(https://archive.mozilla.org/pub/firefox/nightly/2022/10/2022-10-26-22-42-58-mozilla-central/) and Beta build(https://archive.mozilla.org/pub/firefox/candidates/107.0b5-candidates/).
Thank you so much.

I'm sorry, but I'm not sure what I should do with the links you provided.
This issue is also already closed and marked as fixed, so I don't see why I need to do more testing now.

Comment 14

[Monica Chiorean]

Yes the issue is fixed but we need to confirm that by verifying the issue on following builds:

1. On Nightly and you can get the build from here https://archive.mozilla.org/pub/firefox/nightly/2022/10/2022-10-26-22-42-58-mozilla-central/
2. On Beta and you can get the build from here https://archive.mozilla.org/pub/firefox/candidates/107.0b5-candidates/
   Thank you very much.

Comment 15

[logicalwillow]

Okay, thanks. What files do I need to download from those websites and what should I do with them?

Comment 16

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1796849 - Use non-native tooltips in the cocoa non-native theme too. r=mstange,spohl

We implemented a basic ThemeGeometry-based tooltip in
https://hg.mozilla.org/integration/autoland/rev/e8d65866112f, but now
that we have non-native theme support for these it seems ok to just use
it.

Depends on D163022

Comment 17

[Phabricator Automation]

Comment on attachment 9305169 [details]
Bug 1796849 - Use non-native tooltips in the cocoa non-native theme too. r=mstange,spohl

Revision D163023 was moved to bug 1802314. Setting attachment 9305169 [details] to obsolete.

Comment 18

[Monica Chiorean]

(In reply to logicalwillow from comment #15)

Okay, thanks. What files do I need to download from those websites and what should I do with them?

You need to install the latest Firefox Beta build or latest Firefox Nightly build and confirm issue is not reproducing on your side.

Comment 19

[logicalwillow]

The issue has been resolved for me in the stable version.