1797977 - Tooltip rendering is broken in dark windows when the system is in light mode on KDE Plasma

Status: RESOLVED DUPLICATE of bug 1796849

(Core :: Widget: Gtk, defect)

Description

[faded.solivagant]

Attachment: photo_2022-10-28_17-30-17.jpg

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:106.0) Gecko/20100101 Firefox/106.0

Steps to reproduce:

I'm facing this issue on the KDE Plasma Desktop 5.26 (Not sure about other desktops). And It's just happening since Firefox 106.
1- Set theme to "System theme - auto"
2- Set system theme to a light them "Like Breeze Light"
3- Open a Private window

Actual results:

Private window remains dark and un-themed. It doesn't follow system theme and color. Also hover texts are invisible.

Expected results:

It should be light, like normal window. Just with a icon for Private Browsing.
It was correct till FF 106.

Comment 1

[faded.solivagant]

Attachment: photo_2022-10-28_17-29-55.jpg

This is what happens when I hover on something.

Comment 2

[faded.solivagant]

Attachment: This is what I expect it to be.

Comment 3

[faded.solivagant]

Comment on attachment 9300788 [details]
This is what I expect it to be.

This is what I expect it to be.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Can you reproduce that with Mozilla binaries? If so can you try mozregression to find broken commit?
https://fedoraproject.org/wiki/How_to_debug_Firefox_problems#Use_Mozregression_tool
Thanks.

Comment 6

[Kristian Polso]

I am affected by this same bug. I ran through the tests in mozregression, and these are the results:

 5:38.98 INFO: Narrowed integration regression window from [1626cf96, eb01cc55] (3 builds) to [1626cf96, 1c3af1e8] (2 builds) (~1 steps left)
 5:38.98 INFO: No more integration revisions, bisection finished.
 5:38.98 INFO: Last good revision: 1626cf967475716eafd72740facf1e38b4e08ff3
 5:38.98 INFO: First bad revision: 1c3af1e8c29e6704074238bae6a2300bd48f67c0
 5:38.98 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=1626cf967475716eafd72740facf1e38b4e08ff3&tochange=1c3af1e8c29e6704074238bae6a2300bd48f67c0

I am running KDE Plasma 5.26.2 with default Breeze theme.

Hopefully this helps!

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Emilio, do we want to support styling in private windows?
Thanks.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

So, making private windows dark was an intentional change from bug 1751481. It's controlled by browser.theme.dark-private-windows in about:config.

We can't use the system theme on Linux there because we can't load two GTK themes at the same time and switching has unacceptable runtime cost. The tooltip issue in comment 1 is already fixed tho, that was bug 1796849.

So this is a UX issue basically.

Comment 9

[Kristian Polso]

I ran the mozregression tests, I can confirm that the tooltip issue on Comment #1 was fixed on 2022-10-24 nightly release

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

:pbz, since you are the author of the regressor, bug 1751481, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 11

[Dão Gottwald [:dao]]

So as filed this bug is wontifx/invalid as this is basically working as intended. However, the tooltip seen in comment 1 is no good so we should fix that. Based on https://searchfox.org/mozilla-central/rev/aec3a901e6f6b3041b5ec457c9111a042cef1fb1/toolkit/content/xul.css#376,382 it looks like either the tooltip appearance are wrong, or InfoText is wrong, or perhaps we should be using a different text color altogether?

Comment 12

[Emilio Cobos Álvarez (:emilio)]

That was fixed already