Closed Bug 1797155 Opened 1 month ago Closed 27 days ago

OverflowableToolbar should be able to put overflowable WebExtension browser_actions into the Unified WebExtensions panel.

Categories

(Firefox :: Toolbars and Customization, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
108 Branch
Tracking Status
firefox108 --- fixed

People

(Reporter: mconley, Assigned: mconley)

References

(Blocks 1 open bug)

Details

(Whiteboard: [addons-jira])

Attachments

(3 files)

As part of the grander Unified WebExtensions project, we need to make it (when Unified WebExtensions is enabled) such that if a WebExtension browser_action toolbar button is overflowed, it goes into the dedicated Unified WebExtensions panel rather than the traditional overflow panel.

And when the toolbar underflows, it needs to draw from those two separate panels in the same order that the items were inserted in.

Whiteboard: [addons-jira]
Depends on: 1797156
Type: task → enhancement

This patch makes it so that OverflowableToolbar.#moveItemsBackToTheirOrigin
is not coupled to the existing overflowed item list, and instead takes
advantage of the insert-order provided when calling #overflowedInfo.entries()
and queries the DOM for the overflowed item IDs directly.

A later patch in this series is going to conditionally move overflowed
items into different panels based on whether or not they're provided
by WebExtensions, and so this change means that #moveItemsBackToTheirOrigin
is not going to care which panel the overflowed items are in, it should
behave the same.

Depends on: 1797548
Attachment #9300236 - Attachment description: WIP: Bug 1797155 - Part 1: Don't walk the #list children directly in OverflowableToolbar.#moveItemsBackToTheirOrigin. r?Gijs! → Bug 1797155 - Part 1: Don't walk the #list children directly in OverflowableToolbar.#moveItemsBackToTheirOrigin. r?sclements!
Attachment #9300237 - Attachment description: WIP: Bug 1797155 - Part 2: Make it possible to redirect browser action widgets to the Unified Extension panel on overflow. r?Gijs! → Bug 1797155 - Part 2: Make it possible to redirect browser action widgets to the Unified Extension panel on overflow. r?sclements!
Blocks: 1798324
Attachment #9300237 - Attachment description: Bug 1797155 - Part 2: Make it possible to redirect browser action widgets to the Unified Extension panel on overflow. r?sclements! → Bug 1797155 - Part 2: Make it possible to redirect browser action widgets to the Unified Extension panel on overflow. r?sclements!,willdurand!
Regressions: 1798377
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3fbfc3d94e5a
Part 1: Don't walk the #list children directly in OverflowableToolbar.#moveItemsBackToTheirOrigin. r=sclements
https://hg.mozilla.org/integration/autoland/rev/863603ed770a
Part 2: Make it possible to redirect browser action widgets to the Unified Extension panel on overflow. r=sclements,willdurand
https://hg.mozilla.org/integration/autoland/rev/ee3f27f43bc5
Part 3: Add tests for Unified Extensions toolbar overflow behaviour. r=willdurand,extension-reviewers

Backed out 3 changesets (Bug 1797155) for causing bc failures on browser_unified_extensions_overflowable_toolbar.js.
Backout link
Push with failures <--> bc1
Failure Log

Flags: needinfo?(mconley)
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ec7cdd68c414
Part 1: Don't walk the #list children directly in OverflowableToolbar.#moveItemsBackToTheirOrigin. r=sclements
https://hg.mozilla.org/integration/autoland/rev/b8a8bd646606
Part 2: Make it possible to redirect browser action widgets to the Unified Extension panel on overflow. r=sclements,willdurand
https://hg.mozilla.org/integration/autoland/rev/67f5e4af25b6
Part 3: Add tests for Unified Extensions toolbar overflow behaviour. r=willdurand,extension-reviewers
Flags: needinfo?(mconley)

Sorry about that. :/ Doing a broader-range try push now with something that (I think) should address it.

https://treeherder.mozilla.org/jobs?repo=try&revision=c1a6e85bab4891558d65567b67eb2f94886d12a3

Flags: needinfo?(mconley)
Blocks: 1798572
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f6168d45dde0
Part 1: Don't walk the #list children directly in OverflowableToolbar.#moveItemsBackToTheirOrigin. r=sclements
https://hg.mozilla.org/integration/autoland/rev/ddbd0486fb24
Part 2: Make it possible to redirect browser action widgets to the Unified Extension panel on overflow. r=sclements,willdurand
https://hg.mozilla.org/integration/autoland/rev/ff538b4eebc9
Part 3: Add tests for Unified Extensions toolbar overflow behaviour. r=willdurand,extension-reviewers
Status: NEW → RESOLVED
Closed: 27 days ago
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
Regressions: 1798683
You need to log in before you can comment on or make changes to this bug.