1797202 - ASrouter doesn't ingest rollout messages from Nimbus

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Beth Rennie [:beth] (she/her)]

The code that loads messages from Nimbus explicitly checks for an experiment, so if there is a rollout, the message wont be ingested.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

I suspect we're going to need this uplifted to 107 for the Import Bookmarks experiment/rollout pair, since not everyone is going to be enrolled in the experiment. Does that sound right, Barret?

Comment 2

[Beth Rennie [:beth] (she/her)]

Yes

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

[Tracking Requested - why for this release]:

We're going to need this to run the Import Bookmarks Rollout, otherwise the rollout won't work.

Comment 4

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1797202 - Ingest messages from Nimbus rollouts in ASRouter r?dmose

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox107 (beta). However, the bug still has low severity.

:tspurway, could you please increase the severity for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit auto_nag documentation.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/44d716ef7e6e
Ingest messages from Nimbus rollouts in ASRouter r=dmose

Comment 7

[Dan Mosedale (:dmosedale, :dmose)]

Please see https://bugzilla.mozilla.org/show_bug.cgi?id=1797553#c5 for instructions that will verify that both that bug and this one have been fixed.

Comment 8

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/44d716ef7e6e

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:barret, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox107 to wontfix.

For more information, please visit auto_nag documentation.

Comment 10

[Simona Rosu [:srosu], Ecosystem QA]

We‘ve verified this issue using the latest Firefox Nightly 108.0a1 (Build ID: 20221027095047) on Windows 10 x64, macOS 11.6.6, and Linux Mint 20.2 x64.

• The user can be successfully enrolled in both branches of the experiment.
• The user can be successfully enrolled in the rollout while already enrolled in the experiment.
• After enrolling in the rollout on a clean profile, the "Import to <Firefox>" spotlight is displayed with the same image and strings as in the Mana page.
• No specific errors are displayed in the Browser Console after clicking the “Import to <Firefox>” button.
• When the import flow ends, the spotlight modal disappears and the page that was prior to the spotlight modal is displayed.
• We also moved the rollout recipe back to draft.

Comment 11

[Beth Rennie [:beth] (she/her)]

Comment on attachment 9300193 [details]
Bug 1797202 - Ingest messages from Nimbus rollouts in ASRouter r?dmose

Beta/Release Uplift Approval Request

• User impact if declined: We will not be able to do a message rollout on 107 for the Import Bookmarks rollout as planned.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Not risky. Automated tests and QA verified.
  Small patch that only interacts with rollouts; does not change behaviour of existing experiments.
• String changes made/needed:
• Is Android affected?: No

Comment 12

[Donal Meehan [:dmeehan]]

Comment on attachment 9300193 [details]
Bug 1797202 - Ingest messages from Nimbus rollouts in ASRouter r?dmose

Approved for 107.0b6.

Comment 13

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7faf6c473451

Comment 14

[Simona Rosu [:srosu], Ecosystem QA]

We‘ve verified this issue using Firefox Beta 107.0b6 (Build ID: 20221027185833) on Windows 10 x64, macOS 12.6, and Ubuntu 20.04 x64.

• The user can be successfully enrolled in both branches of the experiment.
• The user can be successfully enrolled in the rollout while already enrolled in the experiment.
• After enrolling in the rollout on a clean profile, the "Import to <Firefox>" spotlight is displayed with the same image and strings as on the Mana page.
• No specific errors are displayed in the Browser Console after clicking the “Import to <Firefox>” button.
• When the import flow ends, the spotlight modal disappears and the page that was prior to the spotlight modal is displayed.