1797553 - fxms-message-1 not in MESSAGING_EXPERIMENTS_DEFAULT_FEATURES

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Dan Mosedale (:dmosedale, :dmose)]

+++ This bug was initially created as a clone of Bug #1795349 +++

In order for fxms-message-1 to work correctly as an FxMS experiment feature (which is required to use it in the Bookmarks Import experiment for 107), it needs to be on a special list in ASRouter.

Comment 1

[Ed Lee :Mardak]

https://phabricator.services.mozilla.com/D159418#5233117

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Bug 1797553 - Add fxms-message-1 to default FxMS features, r?negin

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

[Tracking Requested - why for this release]:

This Nimbus feature will be used on a long-lived deployment branch for the Import Bookmarks deployment starting in 107.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b75455c9f10e
Add fxms-message-1 to default FxMS features, r=negin

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Please check that a rollout works correctly. Steps are:

In the QA section of the Import Bookmarks tech plan, do these steps:

high-level-section: 1, 2,3
lower-level steps all (just the rollout, not the experiment)
high-level-section: 7

Executing this will verify both this bug and bug 1797202

Comment 6

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/b75455c9f10e

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:dmosedale, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox107 to wontfix.

For more information, please visit auto_nag documentation.

Comment 8

[Simona Rosu [:srosu], Ecosystem QA]

We‘ve verified this issue using the latest Firefox Nightly 108.0a1 (Build ID: 20221027095047) on Windows 10 x64, macOS 11.6.6, and Linux Mint 20.2 x64.

• The user can be successfully enrolled in both branches of the experiment.
• The user can be successfully enrolled in the rollout while already enrolled in the experiment.
• After enrolling in the rollout on a clean profile, the "Import to <Firefox>" spotlight is displayed with the same image and strings as in the Mana page.
• No specific errors are displayed in the Browser Console after clicking the “Import to <Firefox>” button.
• When the import flow ends, the spotlight modal disappears and the page that was prior to the spotlight modal is displayed.
• We also moved the rollout recipe back to draft.

Comment 9

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 9300415 [details]
Bug 1797553 - Add fxms-message-1 to default FxMS features, r?negin

Beta/Release Uplift Approval Request

• User impact if declined: Won't be able to do long-lived deployment of Import Bookmarks rollout as planned.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See https://bugzilla.mozilla.org/show_bug.cgi?id=1797553#c5
• List of other uplifts needed: Bug 1797202
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very low-risk change involving adding a featureId to a special ASRouter list so that ASRouter treats rollouts / experiments with that featureId as messaging system experiments. Automated test written.
• String changes made/needed: No
• Is Android affected?: No

Comment 10

[Donal Meehan [:dmeehan]]

Comment on attachment 9300415 [details]
Bug 1797553 - Add fxms-message-1 to default FxMS features, r?negin

Approved for 107.0b6.

Comment 11

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/42c01ae59dde

Comment 12

[Simona Rosu [:srosu], Ecosystem QA]

We‘ve verified this issue using Firefox Beta 107.0b6 (Build ID: 20221027185833) on Windows 10 x64, macOS 12.6, and Ubuntu 20.04 x64.

• The user can be successfully enrolled in both branches of the experiment.
• The user can be successfully enrolled in the rollout while already enrolled in the experiment.
• After enrolling in the rollout on a clean profile, the "Import to <Firefox>" spotlight is displayed with the same image and strings as on the Mana page.
• No specific errors are displayed in the Browser Console after clicking the “Import to <Firefox>” button.
• When the import flow ends, the spotlight modal disappears and the page that was prior to the spotlight modal is displayed.