1798138 - Site icons missing in DuckDuckGo search results and some Google tabs (like Docs)

Status: RESOLVED WORKSFORME

(Core :: DOM: Networking, defect)

Description

[Guy]

Attachment: Screenshot_1.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:108.0) Gecko/20100101 Firefox/108.0

Steps to reproduce:

Run a search on https://duckduckgo.com and/or open a Google Doc/Sheet tab

I ran mozregression and found that it broke some time after 27/10/2022 (screenshot attached)

Not sure if I need to share more info from the mozregression, but the bottom text in the log says:

2022-10-29T15:52:40.762000: DEBUG : Found commit message:
Bug 1785331 - Allow Synthesized Request Bypass ORB checks r=smaug,valentin,necko-reviewers

If ORB doesn't block the request from service worker, then the
synthesized request should also not be blocked by ORB.

Differential Revision: https://phabricator.services.mozilla.com/D160382

2022-10-29T15:52:40.762000: DEBUG : Did not find a branch, checking all integration branches
2022-10-29T15:52:40.763000: INFO : The bisection is done.
2022-10-29T15:52:40.764000: INFO : Stopped

Actual results:

DuckDuckGo - Most results don't have an icon for the site (though the icon does show in a new tab if right clicking on the missing icon and selecting Open Image in New Tab. The icon also appears when bookmarking a page from the results)

Google tab - no icon appears on the tab

Expected results:

The site icons should have appeared

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Tabbed Browser' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:sefeng, since you are the author of the regressor, bug 1785331, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The bug has a release status flag that shows some version of Firefox is affected, thus it will be considered confirmed.

Comment 5

[Sean Feng [:sefeng]]

Bug 1797983 will fix this.

Comment 6

[Guy]

It's been solved