1797983 - GDocs favicons no longer display in the tab strip

Status: RESOLVED FIXED

(Core :: DOM: Networking, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

Attachment: Screenshot of problem

STR:

1. Visit this test document
2. Look at the tab strip

ER:

The GDocs favicon should appear.

AR:

The GDocs favicon does not appear. When pinned, the default favicon appears instead.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

ni?ing sefeng per your mailing list post. :)

Comment 2

[Mike Conley (:mconley) (:⚙️)]

(I identified the regression range using mozregression)

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1785331

Comment 4

[Sean Feng [:sefeng]]

Looks like our sniffer failed to identify the ico file was an image. This is Nightly only, so I am changing the status.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

We can set the status to disabled once 108 goes to Beta, but for now 108 is affected.

Comment 6

[Andrew Overholt [:overholt]]

In today's Nightly I see favicons for gdocs but not pinned gdocs or gmail (but it does work for pinned gcal).

Comment 7

[Sean Feng [:sefeng]]

Attachment: Bug 1797983 - Make Sniffing with ORB decompresses contents before making a decision r=farre,valentin

Our current code uses PeekStream to get the data and pass them
over to the sniffer, however it doesn't count the case where the
contents are compressed, so the sniffer would fail to determine
the type of contents.

This patches introduces a sub class of nsHTTPCompressConv which
allows when the sniffer type is ORB, we'll decompresses the first
chunk of the data before making an ORB decision.

Comment 8

[Sean Feng [:sefeng]]

Attachment: Bug 1797983 - Remove ORB checks in InterceptedHttpChannel::OnStartRequest r=farre,valentin

It seems that these stuff aren't really needed because whatever
reaches to here either successfully synthesized requests or requests
with system principal (ie: the requests we manually created in
test_synthesized_response.js).

If those conditions are true, then these ORB checks will have no
effect, so we can remove them.

Depends on D161167

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c12f99543e1
Make Sniffing with ORB decompresses contents before making a decision r=necko-reviewers,farre,valentin
https://hg.mozilla.org/integration/autoland/rev/042e5a858d11
Remove ORB checks in InterceptedHttpChannel::OnStartRequest r=farre,smaug

Comment 10

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/36959 for changes under testing/web-platform/tests

Comment 11

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/5c12f99543e1
https://hg.mozilla.org/mozilla-central/rev/042e5a858d11

Comment 12

[Jim Mathies [:jimm]]

Can we get this work uplifted to 108?

Comment 13

[Sean Feng [:sefeng]]

I don't think we need to since ORB has been turned off in bug 1798227, so 108 doesn't have it?

Comment 16

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 17

[Monica Chiorean]

I was able to reproduce the issue on Win10 using FF build 108.0a1(20221028212211).
Verified as fixed on Win10/Ubuntu 20.04 using builds 109.0b1(20221212143511) and 110.0a1(20221213165020).

Comment 18

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by jgraham