"Copy to <folder> again" menu item not present after copying message to folder with Cyrillic or Japanese name on Gmail
Categories
(Thunderbird :: General, defect)
Tracking
(thunderbird_esr102+ fixed, thunderbird_esr115 unaffected, thunderbird107 wontfix)
Tracking | Status | |
---|---|---|
thunderbird_esr102 | + | fixed |
thunderbird_esr115 | --- | unaffected |
thunderbird107 | --- | wontfix |
People
(Reporter: b5, Assigned: mkmelin)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
wsmwk
:
approval-comm-esr102+
|
Details | Review |
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/106.0.0.0 Safari/537.36
Steps to reproduce:
"Copy to <folder> again" menu item not present after copying message to folder with Cyrillic or Japanese name on Gmail.
It works for other non-ASCII folders, like ones with German Umlaut, e.g. Földer.
Already not working in TB 91 (and likely earlier versions).
Works on Gmail with mail.server.default.allow_utf8_accept set to false. The issue is here:
https://searchfox.org/comm-central/rev/396b593b9d21320bc94a7f248ceabb90a7a418b3/mail/base/content/mailWindowOverlay.js#778
getCharPref()
only handles Latin1, so "Földer" works, but Cyrillic/Japanese doesn't. Should be getStringPref()
.
Likely also wrong:
https://searchfox.org/comm-central/search?q=folder.*getcharpref&path=.js&case=false®exp=true
https://searchfox.org/comm-central/search?q=setcharpref.*folder.*uri&path=mail&case=false®exp=true
Assignee | ||
Updated•1 year ago
|
Assignee | ||
Comment 3•1 year ago
|
||
getCharPref doesn't handle unicode, so the code would fail for e.g. folders with Japanese names if the imap server is set to use utf-8 (allow_utf8_accept).
Updated•1 year ago
|
Assignee | ||
Updated•1 year ago
|
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/4d322994136c
Use getStringPref/setStringPref for folder URI preferences. r=benc
Assignee | ||
Comment 5•1 year ago
|
||
Comment on attachment 9301012 [details]
Bug 1798172 - Use getStringPref/setStringPref for folder URI preferences. r=#thunderbird-reviewers
[Approval Request Comment]
Regression caused by (bug #): never worked?
User impact if declined: move to again, and a few others may not work for all cases
Testing completed (on c-c, etc.): beta
Risk to taking this patch (and alternatives if risky): should be safe
Updated•1 year ago
|
Comment 6•1 year ago
|
||
Comment on attachment 9301012 [details]
Bug 1798172 - Use getStringPref/setStringPref for folder URI preferences. r=#thunderbird-reviewers
[Triage Comment]
Approved for esr102
Comment 7•1 year ago
|
||
bugherder uplift |
Thunderbird 102.5.1:
https://hg.mozilla.org/releases/comm-esr102/rev/e7435167ed9c
Updated•5 months ago
|
Description
•