[Meta] Problems with folders having names with illegal(or special) characters or special name

NEW
Unassigned

Status

MailNews Core
Backend
16 years ago
2 years ago

People

(Reporter: Sheela Ravindran, Unassigned)

Tracking

(Depends on: 37 bugs, {intl, meta, qawanted})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

16 years ago
This bug tracks both imap and local folders having illegal characters as the
name of the folder.
(Reporter)

Comment 1

16 years ago
Tracking the bug numbers with this problem.  As per our discussion leaving
Esther as the owner and qa contact for this bug.  
(Reporter)

Comment 2

16 years ago
Adding two more bugs which should be tracked as well. Thanks Cavin.  
Depends on: 117385, 117840

Updated

16 years ago
Depends on: 125868

Updated

16 years ago
No longer depends on: 125868

Updated

16 years ago
Depends on: 157768

Updated

15 years ago
Depends on: 140212

Updated

15 years ago
Depends on: 120559

Updated

15 years ago
Depends on: 131013

Updated

15 years ago
Depends on: 142464

Comment 3

15 years ago
Created attachment 126194 [details] [diff] [review]
patch

I collected the characters which are problematic from the depending bugs and
made a simple patch that just checks the names for New Folder and Rename Folder
and displays an alert if one of them is contained. I think this could be done
better by escaping the problematic chars, but I don't know enough about where
that is done and if I may change the methods without destroying other
functionality. Setting helpwanted.

Comment 4

15 years ago
I just noticed I'm not allowed to set helpwanted. Could someone please do that
for me?

Comment 5

15 years ago
Created attachment 126559 [details] [diff] [review]
patch v2

Changed the patch because " " and "@" are only problematic if used alone for
folder names.
Attachment #126194 - Attachment is obsolete: true

Comment 6

15 years ago
The current status is this: 

The OK Button of New Folder and Rename Folder was disabled if the name was
empty. This has to be extended for the case the name starts or ends with a space
(which also handles filenames like " ", "  " etc.). Alternatively a message
could be displayed, e.g. "Folder names may not start or end with a space
character." 

For the other chars, I'm going to modify the FILE_ILLEGAL_CHARACTERS constants
in nsCRT.h but I can only test on my Windows PC. So I need some help from Linux
and Mac users to try some filenames containing the characters "#./<>?@\".

Testcase: 

Create a folder named e.g. "abc". Copy a message into it. Rename the folder.
Check if

- the folder is displayed with correct name and path in the Folder pane
- the message shows up in the Thread pane
- the message, when selected, is displayed in the Message Pane

Then enter into the table (below) if everything works or if problems occur.
Before the next test, delete the new folder and be sure to view a different
message in the Message Pane.

char | begin | mid | end
==========================
#    |       |     |  
.    |       |     | 
/    |       |     | 
<    |       |     | 
>    |       |     | 
?    |       |     | 
@    |       |     | 
\    |       |     | 

Updated

14 years ago
Depends on: 232001

Comment 7

14 years ago
Wouldn't it be possible to have folder name be stored as a string and display
that string name instead?  Just a thought here...

Updated

14 years ago
Depends on: 239502

Updated

14 years ago
Depends on: 230961
Depends on: 229522
Depends on: 93666
Problem caused by special characters in folder name is one of the most
puzzleded, embarrassed and strange problems for Mozilla Mail users.
Since problems live long time, not so small number of people ask about these
problems at forums such as Mozillazine.
So I think this bug should be listed in "Known Issues" section of "Release
Notes" as Bug 2654 is listed.
I believe listing-up will also reduce many DUPEs.

Comment 9

14 years ago
all this bugs seen more or less related to each others, if they arent really
dupes...

there are 2 main bugs:

-unable to use of bad folder names
-allow the creating for bad names

fix the 1º, the 2º would be little importance
fix the 2º, the 1º one still needs to be fixed or workaround

esther email is invalid (esther@formerly-netscape.com.tld) and its the owner of
many of this bugs

this are important bug as advocating people to move from OE to mozilla and
hitting this bug is very bad and might cost several users ("if it can open/use
some simple folders, its still full of bugs and so useless")

adding the radar for 1.8a
Flags: blocking1.8a?

Comment 10

14 years ago
This is more of a bug tracking purpose.  This shouldn't block the Mozilla 1.8a
release.

Comment 11

14 years ago
(In reply to comment #6)
> The current status is this: 
> 
> The OK Button of New Folder and Rename Folder was disabled if the name was
> empty. This has to be extended for the case the name starts or ends with a space
> (which also handles filenames like " ", "  " etc.). Alternatively a message
> could be displayed, e.g. "Folder names may not start or end with a space
> character." 
> 
> For the other chars, I'm going to modify the FILE_ILLEGAL_CHARACTERS constants
> in nsCRT.h but I can only test on my Windows PC. So I need some help from Linux
> and Mac users to try some filenames containing the characters "#./<>?@\".
> 
> Testcase: 
> 
> Create a folder named e.g. "abc". Copy a message into it. Rename the folder.
> Check if
> 
> - the folder is displayed with correct name and path in the 

(In reply to comment #6)
> The current status is this: 
> 
> The OK Button of New Folder and Rename Folder was disabled if the name was
> empty. This has to be extended for the case the name starts or ends with a space
> (which also handles filenames like " ", "  " etc.). Alternatively a message
> could be displayed, e.g. "Folder names may not start or end with a space
> character." 
> 
> For the other chars, I'm going to modify the FILE_ILLEGAL_CHARACTERS constants
> in nsCRT.h but I can only test on my Windows PC. So I need some help from Linux
> and Mac users to try some filenames containing the characters "#./<>?@\".
> 
> Testcase: 
> 
> Create a folder named e.g. "abc". Copy a message into it. Rename the folder.
> Check if
> 
> - the folder is displayed with correct name and path in the Folder pane
> - the message shows up in the Thread pane
> - the message, when selected, is displayed in the Message Pane
> 
> Then enter into the table (below) if everything works or if problems occur.
> Before the next test, delete the new folder and be sure to view a different
> message in the Message Pane.
> 
> char | begin | mid | end
> ==========================
> #    |       |     |  
> .    |       |     | 
> /    |       |     | 
> <    |       |     | 
> >    |       |     | 
> ?    |       |     | 
> @    |       |     | 
> \    |       |     | 
> 



Mozilla/5.0 (X11; U; Linux i686; fr-FR; rv:1.6) Gecko/20040122 Debian/1.6-1
+enigmail
+adblock

Y: working : this could stay as it is.
N: NOT working

(1): '.' on *NIX this is the meta for selecting current working directory... so
if it's the only char. we get a dialog saying it already exists... it works...

(2): '/' on *NIX this is the meta for selecting root directory or nothing (a
file could be called "/tmp/test" or "/tmp/////test") ... It generates a SEGFAULT
: killing Moz!!! it's CRITICAL and shoud be an illegal character...

(3): '<' and '>' are shells specials characters : moz creates directory but then
you can't add message to it... it's saying it's not writable... and then you
can't delete it... FIXME: it should be an illegal character...


 char | begin | mid | end
 ==========================
 #    |   N   |  N  |  N
 .    |   N   |     |        (1)
 /    |  !N   |     | 	     (2)
 <    |  !N   |  N  | 	     (3)
 >    |  !N   |  N  | 
 ?    |   N   |     |  	     as (1)
 @    |   Y   |  Y  |  Y
 \    |   Y   |  Y  |  Y
 

I do apoligize for my bad english.

Updated

14 years ago
Flags: blocking1.8a? → blocking1.8a-

Comment 12

14 years ago
Still no comment from Mac users...
Status: NEW → ASSIGNED
Keywords: qawanted
Hardware: PC → All

Updated

14 years ago
Assignee: sspitzer → mbockelkamp
Status: ASSIGNED → NEW

Updated

14 years ago
Status: NEW → ASSIGNED

Comment 13

14 years ago
Test on a Mac (macosX 10.3.4)
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7) Gecko/20040616

legend:

H= folder is hidden/disapears
one Y= show up as a folder
YY= the folder and message show up
YN= folder show up, the message is shown in the summary but not in the preview
or not even shows in the summary
L = Mozilla Locks up or crash (critical)
D = rename will not apply, after reboot the name returns to the old name
D2 = 2 folders, the old name with the message, the new name empty

char | begin | mid | end	just this char
==========================
#    |   H   |  YN |	YN	H	
.    |   H   |  YY |	YY	dont allow, but not give any error, lost access to
mailbox until close mozilla
.. also fails the same way
 (the .name in unix will make a "hidden" file/folder, dont show in finder also)
/    |   L   |  D  |	D2	L
<    |   YY  |  YY |	YY	YY
>    |   YY  |  YY |	YY	YY
?    |   YN  |  YN |	YN	YN		
@    |   YY  |  YY |	YY	YY	
\    |   YY  |  YY |	YY	YY	

~	YY	YY	H	H
±	YY	YY	YN?	YN?
;	YN	YN	YN	YN

below everything was OK

´	YY	YY	YY	YY
`	YY	YY	YY	YY
|	YY	YY	YY	YY
"	YY	YY	YY	YY
$	YY	YY	YY	YY
%	YY	YY	YY	YY
!	YY	YY	YY	YY
(	YY	YY	YY	YY
)	YY	YY	YY	YY
=	YY	YY	YY	YY
*	YY	YY	YY	YY
+	YY	YY	YY	YY
-	YY	YY	YY	YY
:	YY	YY	YY	YY
&	YY	YY	YY	YY
space	YY	YY	YY	YY
(i think there is a bug here somehere, renaming will only apply after reboot, so
copy a folder with the same name will merge the old and new mailbox... i have to
confirm this when i have more time, but if someone can confirm this its welcome 8)

ƒ	YY	YY	YY	YY (mac folder simbol, not f 8)
§	YY	YY	YY	YY
,	YY	YY	YY	YY
[				YY
{				YY
€				YY
_				YY

didnt test all combinations, i'm assuming its OK
also tried just to confirm this groups
\$a
$(a)
${a}

i tried to use all simbols that mac keyboard have directly and some more used ones
i hope that i did check well everything, but its already too late, i may have
miss something 8)

i will try to do the same test in linux, specially for those that also fail in mac

also, i think that this should block aviary, this bugs make mozilla and friends
look very bad when migrating
this is a tracker, but i think that this bug should be 2/3 bugs:

1 local names (rename and friends)
2 remote names (imap)
3 importing names from other clients

all the dependent bugs are dupes of this 3 main bugs

at least 1 and 3 should block aviary and with 1 fixed, 2 is less critical unless
other client break it

bug 3 should replace bad chars with _ , % - and if needed, give numbers to the end:

folder# -> folder%
folder/ -> folder-
folder? -> folder%_1

Comment 14

13 years ago
bug #219586 might have correct some of this problems...

testing is welcome to see what are the problems that still remain

i hope that it fixed what i called bug 1 and 3 in my latest message

Depends on: 219586
Flags: blocking-aviary1.0?

Comment 15

13 years ago
renominate any serious bugs on the dependence list that may still exist... 
minusing the meta bug.
Flags: blocking-aviary1.0? → blocking-aviary1.0-
Depends on: 264467

Updated

13 years ago
Keywords: intl

Comment 16

13 years ago
Maybe it would at least be a good idea to prevent people to create such a folder
by means of mozilla/thunderbird itself. This would be no final cure, but an
improvement for people that use mozilla/thunderbird only
Depends on: 198966
Depends on: 180849
Product: Browser → Seamonkey
(In reply to comment #16)
> Maybe it would at least be a good idea to prevent people to create such a folder
> by means of mozilla/thunderbird itself.
Bug 120559 is the bug of such request, although it refers to "/" problem only
and "/" problem in local folder seems to be fixed.
Depends on: 274558
Depends on: 275770
No longer depends on: 239502
Depends on: 286523
Adding Bug 95114 and Bug 84045 (special character in IMAP path name case) to Dependency tree.
Depends on: 84045, 95114
Summary: Meta bug: Problems with folders having names with illegal characters → Meta bug: Problems with folders having names with illegal(or special) characters

Updated

11 years ago
Depends on: 360961
Depends on: 361255

Updated

11 years ago
Depends on: 366789

Updated

11 years ago
No longer depends on: 366789
Depends on: 379101
Depends on: 232634, 287674, 303729, 308723, 317850
Depends on: 206046
Depends on: 372811
Depends on: 302470, 380594

Updated

11 years ago
No longer depends on: 380594
Depends on: 383423
Depends on: 392156
Depends on: 391556
Depends on: 292197
Depends on: 311339
Depends on: 380954
Depends on: 312265
Depends on: 357312
Depends on: 368739

Updated

10 years ago
Depends on: 408506

Updated

10 years ago
No longer depends on: 408506
Depends on: 416888
Depends on: 358208
Depends on: 316051
Depends on: 431822
Depends on: 434850
Depends on: 436032
Matthias,
Are you still working on this ?
Depends on: 449687
QA Contact: esther → search
Keywords: meta

Updated

9 years ago
Depends on: 291403
Depends on: 399393
Number of critical bugs due to illegal file name character declined. And edge cases of special character case or special name case are being found.
So morphing this bug for tracking of;
 (a) Illegal file name character,
 (b) non-illegal but special file name character and special position in filename
 (c) special file names
     e.g. CON, PRON etc. on MS Win, Creation of saved search folder named Inbox at
     Local Folders before creation of standard Inbox, double hashing due to special
     illegal/character and long file name, etc. etc.
Depends on: 497035
Summary: Meta bug: Problems with folders having names with illegal(or special) characters → [Meta] Problems with folders having names with illegal(or special) characters or special name
Depends on: 259184
No longer depends on: 497035
QA Contact: search → message-display

Updated

9 years ago
Component: MailNews: Message Display → Backend
Product: SeaMonkey → MailNews Core
QA Contact: message-display → backend
Depends on: 505563
Depends on: 507244
Depends on: 533640
Depends on: 538942
Depends on: 541740

Updated

8 years ago
Depends on: 547564
Depends on: 549220
Depends on: 561688
Depends on: 378153
Depends on: 568198
Depends on: 575075
Depends on: 397875
Depends on: 626225
Depends on: 632536
Depends on: 669144
Depends on: 694933
Depends on: 720911
Blocks: 298033
No longer blocks: 298033
Depends on: 298033
Depends on: 727324

Updated

6 years ago
Depends on: 603013
Depends on: 743239

Updated

6 years ago
Depends on: 730449
Depends on: 771487
Depends on: 773579

Updated

5 years ago
Depends on: 752768
Depends on: 787729
Depends on: 822230
Depends on: 817681
Depends on: 366789
FYI.
A reason why problem by ">", "^" "|" or around it may occur in IMAP.
> http://mxr.mozilla.org/comm-central/source/mailnews/imap/src/nsImapCore.h#71
> 71 #define kOnlineHierarchySeparatorUnknown '^'
> 72 #define kOnlineHierarchySeparatorNil '|'
> 74 #define IMAP_URL_TOKEN_SEPARATOR ">"

Updated

5 years ago
Assignee: mbockelkamp → nobody
Status: ASSIGNED → NEW
Depends on: 550032
Depends on: 927827
Depends on: 928661

Comment 22

3 years ago
On July 23rd 2014 I upgraded Mozilla Thunderbird (originally installed from the tar.bz2-Installer, german localization) from 24.6.0 (20140610001341) to 31.0 (20140717165725).

Today I noticed two of my folders under "Local Folders" appearing empty (named "a*Gesichtsbuch" and "a*StudiVZ"). [Not that I couldn't bare with the loss of their content... *SCNR*]
Note the special character "*" in these folders' names.

I closed TB and backupped my mail profile. There the mail is still existent (data file as well as msf file). 
After the next application start both folders appear duplicated in the folder pane, but still empty.
Data is still available in data files in the profile, however you can't see any duplicate files there.

What puzzles me however are two empty folders with 9 characters long hexedecimal names as well as two corresponding msf files in my "Local Folders" folder in the profile, having a creation date identical to the time of the application update.

Additional Version strings:
"Funnelcake January 2011"
"mozillamessaging04 - 1.0"
"Update channel: release"

OS:
Debian Linux 6.0.10 (oldstable), Kernel 3.2.0-0.bpo.4-686-pae

Updated

3 years ago
tracking-thunderbird31: --- → ?

Updated

3 years ago
Depends on: 1047788

Comment 23

3 years ago
Sir George, we generally don't do tracking on meta bugs.   I think the bug you want is bug 992879, which already has a patch and patch author already requested it for TB31. This is the bug were tracking would be appropriate.
tracking-thunderbird31: ? → ---
Depends on: 992879
Depends on: 689942
Removing myslef on all the bugs I'm cced on. Please NI me if you need something on MailNews Core bugs from me.
Depends on: 1223618
You need to log in before you can comment on or make changes to this bug.