1799343 - Simplify XUL popup handling.

Status: RESOLVED FIXED

(Core :: Layout, task)

Description

[Emilio Cobos Álvarez [:emilio]]

• Make non-menulist popups just absolute positioned top-layer items.
• Simplify menulist popups to just be static-positioned items under nsMenuFrame.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1799343 - Simplify XUL popup handling. r=TYLin,#layout

• Make non-menulist popups just absolute positioned top-layer items.
• Simplify menulist popups to just be static-positioned items under
  nsMenuFrame.

We need to keep kPopupList only for nsMenuFrame. In the future it can be
removed, see TODO in xul.css

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a609c8c27ca8
Simplify XUL popup handling. r=TYLin

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34f040f379b1
Remove another test whose expectation no longer holds.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f6358a0b692
Remove another test whose expectation doesn't hold.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3150074bccfd
Fix a crashtest that try didn't catch.

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing multiple crashes

Backout link: https://hg.mozilla.org/integration/autoland/rev/2b23087ff3140191d39297e3565c2aa703b96ca6

Push with failures

Failure log ay11

Failure log crashtest #1

Failure log crashtest #2

Failure log crashtest #3

Failure log crashtest #4

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/493c9ca00c91
Simplify XUL popup handling. r=TYLin

Comment 8

[Cristian Tuns]

Backed out for causing mochitest failures on win7

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_sentence_case_strings.js | Test timed out -

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/42d1b8742662
Simplify XUL popup handling. r=TYLin

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/63c270ba91ad
Remove a last-minute optimization that should work but breaks some automated tests.

Comment 11

[Natalia Csoregi [:nataliaCs]]

Backed out for causing failures on browser_history_after_appMenu.js along with Bug 1799580

• backout: https://hg.mozilla.org/integration/autoland/rev/11d7f4ccadeda544305c611cfa9d959192d7f5b5

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c7654bfb11d
Simplify XUL popup handling. r=TYLin

Comment 13

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/4c7654bfb11d