1800072 - Fix dropmarker type=menu-button after bug 1799343

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, defect)

Description

[Martin Giger [:freaktechnik]]

+++ This bug was initially created as a clone of Bug #1799343 +++

After some test builds it appears that our menu-button dropmarkers are broken after applying the commit from bug 1799343.

Not quite sure yet why exactly, but I assume some of the magic that made the menu-button dropmarker work before isn't working anymore.

By menu-button dropmarkers I mean dropmarkers generated by this: https://searchfox.org/comm-central/rev/5df9c49a11c1eddae1a8372ccea21cea6f605753/mail/base/content/widgets/toolbarbutton-menu-button.js#35-36

Comment 1

[Emilio Cobos Álvarez (:emilio)]

The selector in:

:is(toolbarbutton[type="menu"], button[type="menu"], menulist, menu) > :is(menupopup, panel) {

Is not accounting for type="menu-button". Can you just s/menu-button/button? It's weird that thunderbird would have this extra piece of magic:

https://searchfox.org/mozilla-central/rev/d1fe4b6dd7027a54c17ce3030948a1be354598ab/layout/base/nsCSSFrameConstructor.cpp#4128-4133

Comment 2

[Martin Giger [:freaktechnik]]

Attachment: Bug 1800072 - Use type="menu" instead of type="menu-button". r=#thunderbird-reviewers

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1800072 - Remove special-case for XUL type="menu-button". r=#layout

It broke in bug 1799343, and the TB folks are using type="menu", so
let's remove this.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6625b1c05b83
Remove special-case for XUL type="menu-button". r=jfkthame

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6625b1c05b83

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/07ed16f41179
Use type="menu" instead of type="menu-button". r=Paenglab