Open Bug 179984 Opened 22 years ago Updated 2 years ago

add marking junk mail support to news

Categories

(MailNews Core :: Filters, enhancement)

Product:
MailNews Core
Component:
Filters
Type:
enhancement

Tracking

(Not tracked)

People

(Reporter: sspitzer, Unassigned)

References

(Blocks 2 open bugs)

Details

add junk mail support to news 

step 1), change that PR_FALSE back to PR_TRUE in
nsNntpService::GetCanGetIncomingMessages()

step 2), for news, always disable the "move" UI in the junk controls dialog

and drum roll please...

step 3), call CallFilterPlugins(); after the XOVER is complete

the implementation for OnMessageClassified(const char *aMsgURL, nsMsgJunkStatus
aClassification) is going to be simpler that the other implementaions (for local
and imap) since we can't move.  

(should we allow it so if junk, delete or ignore?)
blocks #11035

*** This bug has been marked as a duplicate of 11035 ***
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → DUPLICATE
Summary: add junk mail support to news → add junk mail support to news
Well, if it blocks it, should it really be marked a dup of bug 11035, or did you
mean to add a dependency, instead?
re-open
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
forgive me, I'm new to bugzilla.

thanks for watching out for me, stephend.
Blocks: 11035
Status: REOPENED → NEW
QA Contact: olgam → laurel
Also, should the comments for

14077   nor   P3   All   alecf@netscape.com   VERI   WONT   Hide Junk Mail for News

Be updated now that this bug is getting worked on?

Cheers,
Karl P
karl, let's leave #14077 alone.  it's ancient history.
I was informed that Junk Mail controls should not work in News accounts. 
However, it appeared to work when I selected the messages and used the menus to
run Junk Mail Controls.  Just reporting it in stone here.  In addition, it
updates the unread mail counts.  It should not do that.  While the computer read
the message, I haven't so it shouldn't update the counts.
*** Bug 208638 has been marked as a duplicate of this bug. ***
Per comment 7, as far as I can tell all junk-related functionality has been 
turned off for News as of 1.4: the JMC dialog does not list News accounts in the 
dropdown, and the Mark as Junk features are all disabled or unavailable while 
reading news.

Should this bug be severity=enhancement?  Or is it part of the spec, wherever 
that may be?
OS: Windows 2000 → All
Hardware: PC → All
maybe update summary to include filters, since the two are similar?
Flags: blocking1.6a?
*** Bug 252608 has been marked as a duplicate of this bug. ***
*** Bug 262132 has been marked as a duplicate of this bug. ***
Blocks: 268344
Product: Browser → Seamonkey
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1a2) Gecko/20060517 SeaMonkey/1.1a] (nightly) (W98SE)

The Junk column is still present in News, and can't be used:
would be good to remove it, or have it work as suggested in this bug.
[Mozilla Thunderbird, version 2 alpha 1 (20060517)] (nightly) (W98SE)

Same bug in TB.
Assigning bugs that I'm not actively working on back to nobody; use
SearchForThis as a search term if you want to delete all related bugmail at
once.
Assignee: dmose → nobody
Component: MailNews: Main Mail Window → MailNews: Backend
Product: Mozilla Application Suite → Core
QA Contact: laurel → backend
Severity: normal → enhancement
Component: MailNews: Backend → MailNews: Filters
QA Contact: backend → filters
Flags: wanted-thunderbird3?
Product: Core → MailNews Core
this would be cool, but marking - based on new driver criteria
https://wiki.mozilla.org/Thunderbird:Release_Driving
Flags: wanted-thunderbird3? → wanted-thunderbird3-
In my zeal to extend bayes trait classification beyond IMAP and LOCAL, I seem to be accidentally implementing the bulk of the backend support for this bug in bug 471833. So I'm going to mark this as blocked by it. After bug 471833, support for mailnews (and RSS for that matter) will be a matter of providing any needed UI.

With the inherited folder properties of bug 478360, we should be able to precisely control the enabling of this, as you probably don't want to download a bunch of news bodies on a high-volume list just to check them for spam.
Depends on: 471833
Since there is no equivalent to Move in news to remove junk messages, jcranmer suggested on IRC that we kill the subthread as the way to remove junk messages in news. Does that sound like the correct approach?

I'm going to go ahead and take this bug.
Assignee: nobody → kent
Status: NEW → ASSIGNED
Target Milestone: --- → Thunderbird 3.0rc1
kill sounds right to me
That sounds like the best approach.
I would think it would give me and I imagine what most people what they are wishing for.

Thanks.
Depends on: 496015
Here's an update of the status of this bug.

Assumming bug 496015 lands as expected, as of TB 3.0 beta 4 much of the infrastructure for junk support in news will have landed, though you would normally use an extension or hidden preference to enable it. You will be able to:

1) enable junk processing on news folders using an inherited folder property,
2) junk UI that sets/clears junk would work on news messages, and
3) a post-classification filter could be created that would kill the subthread if the message exceeds a certain junk threshold.

One piece that would still not work is the action taken when you classify a message as junk. That is, manually classifying as junk would not automatically kill the subthread. But that is not a big change, and perhaps could still be snuck into RC1. It is also likely that an extension could do that.

Another issue is that the news message, when processed by mime in the bayes filter, does not seem to correctly separate the headers from the body. So all of the tokens that should be in headers end up as body tokens. It is not clear what this does, but at least in theory it should reduce the accuracy of the junk management.

I'll try to add to my JunQuilla extension any capability that could be done in an extension, so we could start testing this concept more in TB 3.0
I'm going to remove myself from the assignee for now, as I don't intend to do any more work on this before TB 3.0 / SM 2.0.
Assignee: kent → nobody
Status: ASSIGNED → NEW
Target Milestone: Thunderbird 3.0rc1 → ---
Summary: add junk mail support to news → add marking junk mail support to news
(In reply to Kent James (:rkent) from comment #22)
> ...
> I'll try to add to my JunQuilla extension any capability that could be done
> in an extension, so we could start testing this concept more in TB 3.0

Could the development continue? I tried JunQuilla and gladly found it still works. I posted my trial results in http://mesquilla.com/forum/junquilla/ but as the latest post there is 9 years ago, I paste it here: When running junk controls on a newsgroup folder, it downloads all messages again. This is very slow in large group, and it only succeed once. Running it a second time on the same folder will got lots of "503 Connection refused: Too many open connections from you!" error from server. At least, for newsgroups that is set to read offline, all message bodies could be fetched locally; For those groups that is set to read online, message headers is stored locally (I believe they are in msf files), which is sufficient to run junk control against.
Thanks for the reminder. Currently JunQuilla seems work well.
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.