1800658 - Enable the partially implemented ORB in Nightly again

Status: RESOLVED FIXED

(Core :: DOM: Networking, task)

Description

[Sean Feng [:sefeng]]

All the regressions have been fixed, so we should try to enable it again.

Comment 1

[Sean Feng [:sefeng]]

Attachment: Bug 1800658 - Enable the partially implemented ORB in Nightly again r=smaug

All known regressions are fixed, we should try this again.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c1b9b1a0b6f0
Enable the partially implemented ORB in Nightly again r=smaug

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c1b9b1a0b6f0

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c1b9b1a0b6f0

Comment 5

[Alex Finder]

== Change summary for alert #36114 (as of Thu, 17 Nov 2022 12:04:37 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
8%	sina fcp	android-hw-a51-11-0-aarch64-shippable-qr	warm webrender	422.46 -> 390.38
6%	sina PerceptualSpeedIndex	android-hw-a51-11-0-aarch64-shippable-qr	warm webrender	521.25 -> 490.17
5%	sina LastVisualChange	android-hw-a51-11-0-aarch64-shippable-qr	warm webrender	609.46 -> 580.83

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=36114

Hi Sean! Based on the fcp graph in the alert summary, it looks like your patch caused the improvements above. The other two graphs in the alert summary seem to show more noise however. Could you please confirm if your patch caused these improvements ? Thanks!

Comment 6

[Sean Feng [:sefeng]]

Hi Alex,

I don't really have a good way to confirm my patches caused those improvement. In theory it could, by blocking opaque responses to make processing other responses earlier. I agree it looks like my patch improved it by looking at the graph. I checked the recorded video which looked the same as before, so we were not missing any perceptual contents. I think we are good.