1801150 - L10n regressions from reorg bug 1765629

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Rob Lemley [:rjl]]

• The Macedonian (mk) localized build is missing. It should be built for Daily only

Comment 1

[Rob Lemley [:rjl]]

• The l10n_pre job isn't properly using "by-release-type" in the transform that resolves it. Always resolves to "all-locales", this will be a problem on beta.

Comment 2

[Rob Lemley [:rjl]]

Attachment: Bug 1801150 - Fix resolving by release-type for "locale-list" field in l10n-pre. r=dandarnell

Always used the default value before.

Comment 3

[Rob Lemley [:rjl]]

Attachment: Bug 1801150 - Set l10n locales-file to resolve based on release-type. r=dandarnell

The locales list needs to be different for release/beta builds, but that isn't
permitted by gecko_taskgraph. Some of the transforms for shippable-l10n need to
run before the gecko_taskgraph transforms, others after. This is handled by
creating two TransformSequence objects in a single file and arranging the kind
configuration accordingly.
The result is "locales-file" is now keyed by release-type.

Depends on D162313

Comment 4

[Rob Lemley [:rjl]]

Comment on attachment 9303929 [details]
Bug 1801150 - Fix resolving by release-type for "locale-list" field in l10n-pre. r=dandarnell

[Approval Request Comment]
Regression caused by (bug #): 1765629
User impact if declined: Incorrect localized builds on beta/release
Testing completed (on c-c, etc.): should be on nightly soon
Risk to taking this patch (and alternatives if risky):
Assuming 1765629 is uplifted, this is needed to fix the regressions

Request is for D162313 & D162314.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9f9683bb0b79
Fix resolving by release-type for "locale-list" field in l10n-pre. r=dandarnell
https://hg.mozilla.org/comm-central/rev/91e1e511f8e4
Set l10n locales-file to resolve based on release-type. r=dandarnell

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9303930 [details]
Bug 1801150 - Set l10n locales-file to resolve based on release-type. r=dandarnell

[Triage Comment]
Approved for beta

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9303929 [details]
Bug 1801150 - Fix resolving by release-type for "locale-list" field in l10n-pre. r=dandarnell

[Triage Comment]
Approved for beta

Comment 8

[Daniel Darnell [:dandarnell]]

Thunderbird 108.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/8398f9f980ad
https://hg.mozilla.org/releases/comm-beta/rev/e024d1fe8ee7

Comment 9

[Rob Lemley [:rjl]]

Comment on attachment 9303929 [details]
Bug 1801150 - Fix resolving by release-type for "locale-list" field in l10n-pre. r=dandarnell

[Approval Request Comment]
Fixes for bug 1765629

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9303929 [details]
Bug 1801150 - Fix resolving by release-type for "locale-list" field in l10n-pre. r=dandarnell

[Triage Comment]
approved for esr102

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 102.7.0:
https://hg.mozilla.org/releases/comm-esr102/rev/e8ea7cafbb56
https://hg.mozilla.org/releases/comm-esr102/rev/4802c31a72de