1765629 - L10n repackage changes for splitting comm-strings out of gecko-strings

Status: RESOLVED FIXED

(Thunderbird :: Build Config, task)

Description

[Rob Lemley [:rjl]]

Because Thunderbird uses strings from toolkit, devtools, and other locations, somewhere along the way gecko-strings and comm-strings need to be brought back together.

Since translators have already done the work translating gecko-strings for Firefox, I think it makes sense to handle this at release promotion time as part of shippable-l10n jobs.

The basic idea is to use l10n-central/{locale} and whatever the monorepo for translated comm-strings is. For l10n-central cloning, we can use browser/l10n-changesets.json to get the pinned revisions.

The combining will actually be done in a separate taskcluster task that I'm calling shippable-l10n-pre. The initial implementation creates a single archive containing every locale that's being repackaged. Then, shippable-l10n tasks will use that and skip the clone-locales action.

Comment 1

[Rob Lemley [:rjl]]

Attachment: Bug 1765629 - Create shippable-l10n-pre job to create strings archive. r=dandarnell

shippable-l10n-pre combines l10n-central/{locales} with a l10n-comm monorepo
that contains all Thunderbird locales. It packages them into a taskcluster
artifact that will be used by shippable-l10n, which will no longer need to
run the "clone-locales" action.

Mercurial revisions for l10n-central repositories are taken from
browser/locales/l10n-changesets.json, while the actual locales are taken from
comm/mail/locales/{all-locales,shipped-locales} as appropriate.

This initial version does not have any support for l10n-comm being pinned
to a revision as would be needed for release builds.

Comment 2

[Rob Lemley [:rjl]]

Attachment: Bug 1765629 - Modify shippable-l10n to depend on shippable-l10n-pre. r=dandarnell

Changes to l10n repackaging to use the string translations artifact from
shippable-l10n-pre rather than cloning l10n-central repositories itself.

Depends on D144219

Comment 3

[Rob Lemley [:rjl]]

Attachment: langpack-check.zip

I ran comparisons of the langpacks built by the current and new processes over the weekend.

There were differences found. However, I was able to attribute them to changes made in l10n-central via Pontoon that hadn't been picked up in comm-l10n yet.

Output from diffoscope attached for posterity.

Comment 4

[Rob Lemley [:rjl]]

Attachment: Bug 1765629 - Adjust l10n-bump and merge-automation jobs to handle comm-l10n monorepo. r=dandarnell

Depends on D144220

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d6cd95d415e0
Create shippable-l10n-pre job to create strings archive. r=dandarnell
https://hg.mozilla.org/comm-central/rev/c8e58d3c3951
Modify shippable-l10n to depend on shippable-l10n-pre. r=dandarnell
https://hg.mozilla.org/comm-central/rev/f5eb91b48cbb
Adjust l10n-bump and merge-automation jobs to handle comm-l10n monorepo. r=dandarnell

Comment 6

[Rob Lemley [:rjl]]

Comment on attachment 9273139 [details]
Bug 1765629 - Create shippable-l10n-pre job to create strings archive. r=dandarnell

[Approval Request Comment]
Regression caused by (bug #): N/A
User impact if declined: Localized builds might get messy.
Testing completed (on c-c, etc.): nightly
Risk to taking this patch (and alternatives if risky):
Medium risk. While the localized builds and langpacks that get built after this change are correct, I have found two problems just this morning which are/will be fixed in bug 1801150.

Request is for all patches on this bug.

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9303515 [details]
Bug 1765629 - Adjust l10n-bump and merge-automation jobs to handle comm-l10n monorepo. r=dandarnell

[Triage Comment]
Approved for beta

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9273139 [details]
Bug 1765629 - Create shippable-l10n-pre job to create strings archive. r=dandarnell

[Triage Comment]
Approved for beta

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9273140 [details]
Bug 1765629 - Modify shippable-l10n to depend on shippable-l10n-pre. r=dandarnell

[Triage Comment]
Approved for beta

Comment 10

[Daniel Darnell [:dandarnell]]

Thunderbird 108.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/d118ad8e9e3c
https://hg.mozilla.org/releases/comm-beta/rev/38a9da881965
https://hg.mozilla.org/releases/comm-beta/rev/2301ad5eea51

Comment 11

[Rob Lemley [:rjl]]

Comment on attachment 9273139 [details]
Bug 1765629 - Create shippable-l10n-pre job to create strings archive. r=dandarnell

[Approval Request Comment]
Regression caused by (bug #): N/A
User impact if declined: Minimal, potentially a future critical fix will need new strings, without this there is no way to get translations
Testing completed (on c-c, etc.): beta for about 2 cycles
Risk to taking this patch (and alternatives if risky):
There are regressions that have been identified and fixed on beta. At this point, most of the problems should be identified and fixed.

Uplift order: bug 1765629 - bug 1766080 - bug 1801150 - bug 1807161

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9273139 [details]
Bug 1765629 - Create shippable-l10n-pre job to create strings archive. r=dandarnell

[Triage Comment]
approved for esr102

Comment 13

[Rob Lemley [:rjl]]

Thunderbird 102.7.0:
https://hg.mozilla.org/releases/comm-esr102/rev/e53ed363155f
https://hg.mozilla.org/releases/comm-esr102/rev/29f0e058c4fa
https://hg.mozilla.org/releases/comm-esr102/rev/e0706ef64ffc