1801298 - Fix down/up arrow behavior with multiple selectable elements per row

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Dão Gottwald [:dao]]

From https://phabricator.services.mozilla.com/D161776:

while pressing down to go down the list of results, it focuses on each meatball menu button. That could mess up users' muscle memory. I recognize that the placeholder is shown on each result because the logic of showing/adding the button on a result will come in future patches, but while testing this I found it a bit jarring that I had to press down extra times to select a non-heuristic result.

I agree with jteow. I think we discussed that down/up arrow keys should skip this button while tab should not.

Comment 1

[Marco Bonardo [:mak]]

I agree with having up/down always go through results, while tab moves through "widgets" inside results.
The only special case may be quick actions, but I think we didn't find the right compromise there yet.

Comment 2

[Stephanie Cunnane [:scunnane]]

It may be a good idea to coordinate with UX on the best solution here.

Comment 3

[Dale Harvey (:daleharvey)]

I just wanted to ask / clarify in reply to Marco's point that we may not want to do this for quickactions. I think based on feedback we almost certainly want this behaviour for QuickActions, in that the down arrow would select the first Action when present then move on to the next UrlbarResult as opposed to the next action and tab would be used to select any further buttons / actions.

Comment 4

[Marco Bonardo [:mak]]

(In reply to Dale Harvey (:daleharvey) from comment #3)

I just wanted to ask / clarify in reply to Marco's point that we may not want to do this for quickactions. I think based on feedback we almost certainly want this behaviour for QuickActions, in that the down arrow would select the first Action when present then move on to the next UrlbarResult as opposed to the next action and tab would be used to select any further buttons / actions.

I agree. Sorry if I was not clear, I actually meant to delegate the decision to you by saying that "we didn't find the right compromise yet", but I wasn't explicit with that.

Comment 5

[Dão Gottwald [:dao]]

Attachment: Bug 1801298 - Fix down/up arrow behavior with multiple selectable elements per row. r=adw

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/357170b2f52a
Fix down/up arrow behavior with multiple selectable elements per row. r=adw

Comment 7

[Sandor Molnar]

Backed out for causing bc failures in browser/components/urlbar/tests/browser-tips/browser_selection.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/f80a792ac5d811335bfabf50281e1cddf32dcda3

Push with failures

Failure log: INFO - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser-tips/browser_selection.js | Uncaught exception in test - at chrome://mochitests/content/browser/browser/components/urlbar/tests/browser-tips/browser_selection.js:63 - TypeError: can't access property "classList", UrlbarTestUtils.getSelectedElement(...) is null

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ef3c1d1f5d8
Fix down/up arrow behavior with multiple selectable elements per row. r=adw

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2ef3c1d1f5d8

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit auto_nag documentation.

Comment 11

[Vlad Lucaci, Desktop QA (:vlucaci)]

Confirming this issue as verified fixed on 112.0a1(20230223094032) and 111.0b4(20230221190142) using Windows 11, macOS 13 and Ubuntu22.